[
https://issues.apache.org/jira/browse/TINKERPOP-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486764#comment-17486764
]
ASF GitHub Bot commented on TINKERPOP-2681:
-------------------------------------------
spmallette commented on pull request #1555:
URL: https://github.com/apache/tinkerpop/pull/1555#issuecomment-1029529040
not sure who else is looking at this but you may want to pump the brakes a
bit. i found some holes in `mergeE()` while writing more tests and kelvin, as
he was writing documentation, suggested a small refinement to me privately to
allow the `Direction` options to take an `T.id` in addition to a `Vertex` which
should streamline the syntax a bit. he also suggested a slightly larger
adjustment that would allow for `from` and `to` usage rather than `OUT` and
`IN` which is sort of appealing as it matches the Gremlin edge creation syntax.
still thinking about the impact of that one, but I like how it sounds. I will
post back when i have some more code pushed for all this as well as the
existing feedback already on this PR. Thanks for all the attention this has
been given.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create merge() step to codify best practice for upsert pattern
> --------------------------------------------------------------
>
> Key: TINKERPOP-2681
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2681
> Project: TinkerPop
> Issue Type: Improvement
> Components: language, process
> Affects Versions: 3.5.1
> Reporter: Dave Bechberger
> Assignee: Stephen Mallette
> Priority: Major
>
> Create a step that codifies the best practice for the upsert functionality
> into a single step to make it easier to use, more discoverable, and easier
> for implementers to optimize.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
