[
https://issues.apache.org/jira/browse/TINKERPOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490968#comment-17490968
]
ASF GitHub Bot commented on TINKERPOP-2518:
-------------------------------------------
mikepersonick commented on a change in pull request #1565:
URL: https://github.com/apache/tinkerpop/pull/1565#discussion_r804729876
##########
File path: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs
##########
@@ -772,8 +772,16 @@ private GraphTraversal(ICollection<ITraversalStrategy>
traversalStrategies, Byte
/// </summary>
public GraphTraversal<S, E> HasId (object id, params object[] otherIds)
{
- var args = new List<object>(1 + otherIds.Length) {id};
Review comment:
Florian, thanks the review and merge on the other PR. I’m out today so
I’ll take a closer look on Monday, but I guess my general feeling is that
whatever the semantics are on `null` (or anything else), it’s probably best to
handle them in the query execution layer rather than the language bindings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Enhance .NET gherkin framework to deal with more advanced assertions
> --------------------------------------------------------------------
>
> Key: TINKERPOP-2518
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2518
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Assignee: Florian Hockmann
> Priority: Major
>
> There are two pull requests which introduced some "ignores" for tests in .NET:
> https://github.com/apache/tinkerpop/pull/1383
> https://github.com/apache/tinkerpop/pull/1387
> In both cases the Gremlin seems to work fine but the assertions aren't robust
> enough in the framework to handle the results (i think). We should try to
> settle this before 3.5.0 release.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
