[
https://issues.apache.org/jira/browse/TINKERPOP-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494633#comment-17494633
]
ASF GitHub Bot commented on TINKERPOP-2707:
-------------------------------------------
spmallette opened a new pull request #1571:
URL: https://github.com/apache/tinkerpop/pull/1571
https://issues.apache.org/jira/browse/TINKERPOP-2707
Not closing these sessions could end in a leak if a user opts to get a
little loose with the expected API calls for properly handling sessions. This
change should prevent accidents.
Builds with `mvn clean install -pl gremlin-python`
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Closing parent connection in python should close tx() connections
> -----------------------------------------------------------------
>
> Key: TINKERPOP-2707
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2707
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.5.2
> Reporter: Stephen Mallette
> Priority: Blocker
>
> If you do:
> {code}
> graph=Graph()
> connection = DriverRemoteConnection(endpoint,'g',
>
> transport_factory=lambda:AiohttpTransport(call_from_event_loop=True))
> g = graph.traversal().withRemote(connection)
> tx = g.tx()
> gtx = tx.begin()
> try:
> id1 = gtx.addV('id1').next()
> id2 = gtx.addV('id2').next()
> except Exception as e:
> tx.rollback()
> else:
> print(id1,id2)
>
> connection.close()
> {code}
> The connection in {{tx}} won't be closed and it will be up to the server to
> timeout the connection in its normal fashion. While this isn't the expected
> way {{tx}} should be used, it is a bit of a hole someone could stumble in.
> Seems like, the close of the parent {{connection}} should also close any
> spawned child connections. It might be worth looking at Java to see how the
> implementation works there as well.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
