[ 
https://issues.apache.org/jira/browse/TINKERPOP-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508715#comment-17508715
 ] 

ASF GitHub Bot commented on TINKERPOP-2652:
-------------------------------------------

spmallette commented on pull request #1542:
URL: https://github.com/apache/tinkerpop/pull/1542#issuecomment-1072292046


   I don't have a lot of technical advantages of 1 over 2 of list, but I don't 
find 2 more compelling than 1 either to spend time reworking it. @krlawrence 
who did most of the PR indicated earlier in this discussion that he preferred 
the naming he chose and it is consistent with what the TinkerPop graph 
community has been used to seeing since 2015 with Titan to JanusGraph to 
DataStax Graph.  Personally, I'm fine to stick with it on those grounds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Add TextP.regex to the text predicate set
> -----------------------------------------
>
>                 Key: TINKERPOP-2652
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2652
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.6.0
>            Reporter: Kelvin Lawrence
>            Assignee: Kelvin R. Lawrence
>            Priority: Major
>             Fix For: 3.6.0
>
>
> We have over the years, going back to a discussion thread from January 2018 
> [https://lists.apache.org/thread/r76r47jjxmomz9hvsx96www6r8qnh60t] had 
> discussions of various text predicates that Gremlin lacks but are commonly 
> found in other query languages such as SPARQL and Cypher. We currently have 
> some TextP predicates, but not a specific regex one. I propose we add 
> TextP.regex and for the reference implementation leverage the Java Pattern 
> and Matcher classes. It may be that other implementations will choose to use 
> a different REGEX engine but at least this will get the support into the 
> Gremlin language. As a first pass, I envision this can be something quite 
> simple along these lines (from a small prototype I put together).
>  
> {code:java}
>          \,,,/
>          (o o)
> -----oOOo-(3)-oOOo-----
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> gremlin> g=traversal().withGraph(TinkerGraph.open())
> ==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
> gremlin> g.addV('test').property('k1','I like llamas')
> ==>v[0]
> gremlin> g.V().has('k1',TextP.regex("l[i|x]ke"))
> ==>v[0]
> gremlin> g.V().has('city',TextP.regex("^Dallas"))                             
>               
> ==>v[8]                                                                       
>               
> ==>v[186] {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to