[
https://issues.apache.org/jira/browse/TINKERPOP-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616445#comment-17616445
]
ASF GitHub Bot commented on TINKERPOP-2794:
-------------------------------------------
FlorianHockmann commented on PR #1818:
URL: https://github.com/apache/tinkerpop/pull/1818#issuecomment-1276238050
> I rebased on 3.5-dev and now a test failed, but I don't it's really caused
by anything from the rebase. It's probably a timing issue. I'll look into that.
I think I've found and solved the problem with the latest update here. The
test probably just checked already whether the message was sent before that
actually happened as sending messages happens asynchronously in the background.
Adding a simple delay should solve this.
I ran the GitHub Action for the .NET build 5 times in a row and it passed
every time.
> Allow cancellation of Gremlin.Net async methods
> -----------------------------------------------
>
> Key: TINKERPOP-2794
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2794
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Reporter: Bill Poole
> Assignee: Florian Hockmann
> Priority: Major
>
> Gremlin.Net async methods such as Promise do not accept a CancellationToken
> parameter and cannot therefore be cancelled. Applications often need to be
> closed quickly/responsively when a user quits or an application server
> component is shut down/rebooted - e.g., during cluster auto
> scaling/rebalancing.
> All async methods should accept a CancellationToken parameter (which can be
> given a default value of 'default').
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
