[ 
https://issues.apache.org/jira/browse/TINKERPOP-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623148#comment-17623148
 ] 

ASF GitHub Bot commented on TINKERPOP-2818:
-------------------------------------------

spmallette commented on PR #1836:
URL: https://github.com/apache/tinkerpop/pull/1836#issuecomment-1288967771

   sorry - you are right. i'm not sure why i thought `jcabi-log` was 0.14. it 
is in fact 0.20. it's curious that `mockito-core` does not show in the 
`dependency:tree` though:
   
   ```text
   [INFO] org.apache.tinkerpop:gremlin-core:jar:3.5.5-SNAPSHOT
   [INFO] +- org.apache.tinkerpop:gremlin-shaded:jar:3.5.5-SNAPSHOT:compile
   [INFO] +- org.apache.tinkerpop:gremlin-language:jar:3.5.5-SNAPSHOT:compile
   [INFO] |  \- org.antlr:antlr4-runtime:jar:4.9.1:compile
   [INFO] +- org.apache.commons:commons-configuration2:jar:2.8.0:compile
   [INFO] |  \- commons-logging:commons-logging:jar:1.2:compile
   [INFO] +- commons-beanutils:commons-beanutils:jar:1.9.4:compile
   [INFO] +- commons-collections:commons-collections:jar:3.2.2:compile
   [INFO] +- org.apache.commons:commons-lang3:jar:3.11:compile
   [INFO] +- org.apache.commons:commons-text:jar:1.9:compile
   [INFO] +- org.yaml:snakeyaml:jar:1.32:compile
   [INFO] +- org.javatuples:javatuples:jar:1.2:compile
   [INFO] +- com.carrotsearch:hppc:jar:0.7.1:compile
   [INFO] +- com.jcabi:jcabi-manifests:jar:1.2.1:compile
   [INFO] |  \- com.jcabi:jcabi-log:jar:0.20.0:compile
   [INFO] +- com.squareup:javapoet:jar:1.8.0:compile
   [INFO] +- net.objecthunter:exp4j:jar:0.4.8:compile
   [INFO] +- org.slf4j:slf4j-api:jar:1.7.25:compile
   [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
   [INFO] +- junit:junit:jar:4.13.1:test
   [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.25:test
   [INFO] |  \- log4j:log4j:jar:1.2.17:test
   [INFO] +- org.mockito:mockito-core:jar:3.3.3:test
   [INFO] |  +- net.bytebuddy:byte-buddy:jar:1.10.5:test
   [INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.10.5:test
   [INFO] |  \- org.objenesis:objenesis:jar:2.4:test
   [INFO] +- org.hamcrest:hamcrest:jar:2.2:test
   [INFO] +- com.google.testing.compile:compile-testing:jar:0.19:test
   [INFO] |  +- com.google.truth:truth:jar:1.1:test
   [INFO] |  |  +- com.google.auto.value:auto-value-annotations:jar:1.7.4:test
   [INFO] |  |  \- org.ow2.asm:asm:jar:9.0:test
   [INFO] |  +- com.google.auto.value:auto-value:jar:1.7.4:test
   [INFO] |  +- com.google.auto:auto-common:jar:0.11:test
   [INFO] |  \- com.sun:tools:jar:1.8.0_312:system
   [INFO] +- com.google.guava:guava:jar:31.1-jre:test
   [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
   [INFO] |  +- 
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
   [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:test
   [INFO] |  +- org.checkerframework:checker-qual:jar:3.12.0:test
   [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:1.3:test
   [INFO] \- com.google.errorprone:error_prone_annotations:jar:2.4.0:test
   ```
   
   Also noticing that `mockito-core` is showing up in our zip distributions, 
but oddly not the version used by `jcabi-log` at 3.4.6 but 3.3.3 (which is the 
version we use for "test" `<scope>`). I'm not sure why that doesn't conflict on 
build. It's almost like defining the dependency as "test" in our pom just 
overrides the transitively defined one without my having to explicitly 
`<exclude>` which I'm a bit confused by. I really would have expected the 
enforcer plugin to get angry with this conflict but perhaps it doesn't know to 
care given how `dependency:tree` looks. 🤷 
   
   So, I suppose your issue here is valid, however, this seems like a temporary 
fix - shouldn't the real fix be a PR to `jcabi-log` to make `mockito-core` 
"test" `<scope>`? 
   
   




> exclude mockito-core in gremlin-core [compile scope] (import by 
> jcabi-manifests)
> --------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2818
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2818
>             Project: TinkerPop
>          Issue Type: Improvement
>    Affects Versions: 3.6.1
>            Reporter: ningpeipei
>            Priority: Major
>
> jcabi-manifests -->  jcabi-log -->  mockito-core



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to