[
https://issues.apache.org/jira/browse/TINKERPOP-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629172#comment-17629172
] ASF GitHub Bot commented on TINKERPOP-2806: ------------------------------------------- codecov-commenter commented on PR #1837: URL: https://github.com/apache/tinkerpop/pull/1837#issuecomment-1304055994 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1837?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1837](https://codecov.io/gh/apache/tinkerpop/pull/1837?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a9e0ed) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/f88755a418ce270231ce0893813ae141281416d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f88755a) will **decrease** coverage by `5.67%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.6-dev #1837 +/- ## ============================================= - Coverage 69.66% 63.98% -5.68% ============================================= Files 852 23 -829 Lines 38058 3679 -34379 Branches 5620 0 -5620 ============================================= - Hits 26512 2354 -24158 + Misses 9737 1156 -8581 + Partials 1809 169 -1640 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...nkerpop/gremlin/groovy/engine/GremlinExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2dyb292eS9lbmdpbmUvR3JlbWxpbkV4ZWN1dG9yLmphdmE=) | | | | [.../apache/tinkerpop/gremlin/server/GraphManager.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmFwaE1hbmFnZXIuamF2YQ==) | | | | [...pop/gremlin/server/op/AbstractEvalOpProcessor.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9vcC9BYnN0cmFjdEV2YWxPcFByb2Nlc3Nvci5qYXZh) | | | | [...e/tinkerpop/gremlin/server/op/session/Session.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9vcC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | | | | [...mlin/server/op/traversal/TraversalOpProcessor.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9vcC90cmF2ZXJzYWwvVHJhdmVyc2FsT3BQcm9jZXNzb3IuamF2YQ==) | | | | [...pop/gremlin/server/util/ServerGremlinExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL1NlcnZlckdyZW1saW5FeGVjdXRvci5qYXZh) | | | | [...remlin/structure/util/reference/ReferencePath.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9yZWZlcmVuY2UvUmVmZXJlbmNlUGF0aC5qYXZh) | | | | [...rocess/traversal/step/map/EdgeOtherVertexStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9FZGdlT3RoZXJWZXJ0ZXhTdGVwLmphdmE=) | | | | [.../traversal/step/sideEffect/TreeSideEffectStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3NpZGVFZmZlY3QvVHJlZVNpZGVFZmZlY3RTdGVwLmphdmE=) | | | | [...gremlin/process/traversal/util/BytecodeHelper.java](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0J5dGVjb2RlSGVscGVyLmphdmE=) | | | | ... and [865 more](https://codecov.io/gh/apache/tinkerpop/pull/1837/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Provide method for provider plugins to get notified on script/query > processing > ------------------------------------------------------------------------------- > > Key: TINKERPOP-2806 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2806 > Project: TinkerPop > Issue Type: Bug > Components: server > Affects Versions: 3.6.1 > Reporter: Tom Kolanko > Priority: Minor > Fix For: 3.6.2 > > > What happens in the gremlin-server is more or less a black box for provider > plugins. This ticket proposes a change to the GraphManager interface to allow > providers to opt into receiving notifications for GremlinExecutor lifecycles. > The following items could be added to the GraphManager interface: > /** > * This method will be called before a script or query is processed by the > * gremlin-server. > * The msg is the {@link RequestMessage} received by the gremlin-server. > */ > default void beforeQueryStart(RequestMessage msg) { > } > /** > * This method will be called before a script or query is processed by the > * gremlin-server. > * The msg is the {@link RequestMessage} received by the gremlin-server. > * The error is the exception encounted during processing from the > gremlin-server. > */ > default void onQueryError(RequestMessage msg, Throwable error) { > } > /** > * When a script or query successfully completes this method will be > called. > * The msg is the {@link RequestMessage} received by the gremlin-server. > */ > default void onQuerySuccess(RequestMessage msg) { > } > In AbstractEvalOpProcessor where the GremlinExector.LifeCycle is created the > graphManager can be accessed through the Context and those methods called at > each stage of the lifecycle. > In TraversalOpProcessor the graphManager can also be accessed through > context. Similar methods exist to the GremlinExecutor.LifeCycle, those can > call the graphManager methods as needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
