[
https://issues.apache.org/jira/browse/TINKERPOP-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631958#comment-17631958
]
ASF GitHub Bot commented on TINKERPOP-2819:
-------------------------------------------
codecov-commenter commented on PR #1850:
URL: https://github.com/apache/tinkerpop/pull/1850#issuecomment-1311005947
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1850](https://codecov.io/gh/apache/tinkerpop/pull/1850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(d94588e) into
[master](https://codecov.io/gh/apache/tinkerpop/commit/8023179a2a86e9256c75093a423bee6204251806?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8023179) will **decrease** coverage by `0.76%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1850 +/- ##
============================================
- Coverage 69.18% 68.41% -0.77%
+ Complexity 9314 9082 -232
============================================
Files 875 852 -23
Lines 41759 40971 -788
Branches 5623 5594 -29
============================================
- Hits 28889 28029 -860
- Misses 10893 10977 +84
+ Partials 1977 1965 -12
```
| [Impacted
Files](https://codecov.io/gh/apache/tinkerpop/pull/1850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...in/structure/io/binary/types/LambdaSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0xhbWJkYVNlcmlhbGl6ZXIuamF2YQ==)
| `12.50% <0.00%> (-87.50%)` | :arrow_down: |
|
[.../structure/io/binary/types/PropertySerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL1Byb3BlcnR5U2VyaWFsaXplci5qYXZh)
| `22.22% <0.00%> (-77.78%)` | :arrow_down: |
|
[...tructure/io/binary/types/ByteBufferSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0J5dGVCdWZmZXJTZXJpYWxpemVyLmphdmE=)
| `22.22% <0.00%> (-77.78%)` | :arrow_down: |
|
[...mlin/structure/io/binary/types/CharSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0NoYXJTZXJpYWxpemVyLmphdmE=)
| `10.00% <0.00%> (-75.00%)` | :arrow_down: |
|
[...tructure/io/binary/types/OffsetTimeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL09mZnNldFRpbWVTZXJpYWxpemVyLmphdmE=)
| `25.00% <0.00%> (-75.00%)` | :arrow_down: |
|
[...cture/io/binary/types/ZonedDateTimeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL1pvbmVkRGF0ZVRpbWVTZXJpYWxpemVyLmphdmE=)
| `25.00% <0.00%> (-75.00%)` | :arrow_down: |
|
[...ture/io/binary/types/OffsetDateTimeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL09mZnNldERhdGVUaW1lU2VyaWFsaXplci5qYXZh)
| `25.00% <0.00%> (-75.00%)` | :arrow_down: |
|
[...lin/structure/io/binary/types/GraphSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0dyYXBoU2VyaWFsaXplci5qYXZh)
| `6.81% <0.00%> (-71.60%)` | :arrow_down: |
|
[...n/structure/io/binary/types/BindingSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0JpbmRpbmdTZXJpYWxpemVyLmphdmE=)
| `28.57% <0.00%> (-71.43%)` | :arrow_down: |
|
[...cture/io/binary/types/LocalDateTimeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0xvY2FsRGF0ZVRpbWVTZXJpYWxpemVyLmphdmE=)
| `28.57% <0.00%> (-71.43%)` | :arrow_down: |
| ... and [55
more](https://codecov.io/gh/apache/tinkerpop/pull/1850/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Refactor SimpleSocketServer to be accessible to all GLV's
> ---------------------------------------------------------
>
> Key: TINKERPOP-2819
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2819
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Reporter: Cole Greer
> Priority: Major
>
> Currently there is a large gap in the testing capabilities of the java driver
> compared to the other GLV's. Part of this gap is the java driver has
> SimpleSocketServer which provides a useful platform to write tests which
> require specific response behaviour from the server. Having such a tool for
> all of the GLV's would allow for testing of many more potential failure cases
> as well as taking a step towards standardizing the testing approach for all
> GLV's.
> This work can be divided into 2 main parts.
> Part One: Decoupling SimpleSocketServer from the java driver. This is the
> most disruptive part of the proposed changes. This has already been discussed
> [here|https://lists.apache.org/thread/vd7w43xjzvc5rr0135gql9mxhdlcltr9] on
> the dev list but I will summarize. To avoid having all the GLV's depending on
> the java driver, SimpleSocketServer and it's related classes should be
> extracted to a new module gremlin-tools/gremlin-socket-server. Unfortunately
> the socket server still relies on the following classes in gremlin driver:
> tinkerpop.gremlin.driver.message.*
> tinkerpop.gremlin.driver.ser.*
> tinkerpop.gremlin.driver.MessageSerializer
> tinkerpop.gremlin.driver.Tokens
> To avoid a cyclic dependency between gremlin-driver and
> gremlin-socket-server. these classes should be moved to another new module
> gremlin-util which will house any classes which are to be shared between the
> driver and server. Moving these classes to a new module and package will
> break import lines and will need to be left until 3.7. If this added testing
> capability is desired in 3.5 a potential solution is to move the classes to
> the gremlin-util module, but leave them in the gremlin.driver package. In
> initial tests this seems to work without issue although it is an unusual way
> to structure the code and should not be considered a long term solution.
> The second part of this refactor is to reconfigure the newly extracted
> gremlin-socket-server to be usable by all of the GLV's. My initial thoughts
> are to dockerize the server and have the container run during the testing
> phase of the GLV's. There is still some consideration to be done as to how
> the GLV's should best interact with this server. Currently Junit will start
> and stop the server for each individual test, each test has direct access to
> the server object and can control it as needed. The GLV's will not have the
> same direct control over the server. Any control options or behaviour needed
> will either need to be encoded in the server itself as custom behaviour
> triggered by specific request ID's or control through some external wrapper
> or interface around the server. There is still consideration needed as to how
> this should be done. Any comments on desired functionality or behaviour would
> be greatly appreciated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
