[
https://issues.apache.org/jira/browse/TINKERPOP-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640329#comment-17640329
]
ASF GitHub Bot commented on TINKERPOP-2348:
-------------------------------------------
vkagamlyk commented on code in PR #1875:
URL: https://github.com/apache/tinkerpop/pull/1875#discussion_r1034208025
##########
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##########
@@ -127,20 +127,20 @@ public void TranslateTraversal(string traversalText)
throw new InvalidOperationException("g should be a traversal
source");
}
- if (ScenarioData.CurrentFeature.Tags.Select(t =>
t.Name).ToList().Contains("@GraphComputerOnly"))
+ if (ScenarioData.CurrentFeature!.Tags.Select(t =>
t.Name).ToList().Contains("@GraphComputerOnly"))
Review Comment:
why is there `.ToList()` needed?
```suggestion
if (ScenarioData.CurrentFeature!.Tags.Any(t => t.Name ==
"@GraphComputerOnly"))
```
> Enable nullable checks
> ----------------------
>
> Key: TINKERPOP-2348
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2348
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.4.11
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Minor
> Fix For: 3.7.0
>
>
> Gremlin.NET should enable [nullable
> checks|https://devblogs.microsoft.com/dotnet/embracing-nullable-reference-types/]
> to clearly communicate to users what can be {{null}} in Gremlin.NET and also
> to possibly find possible {{NullReferenceExceptions}} easier in our own code.
> The recommendation from Microsoft is to update libraries during the so-called
> _"nullable rollout phase"_ which ends in November with the expected release
> of .NET 5 which should have nullable checks enabled by default.
> We can add .NET Core 3.1 as an additional target framework to get the
> nullable checks and still also target .NET Standard to stay platform
> independent and to also still support .NET Framework and older .NET Core
> versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
