[ 
https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644514#comment-17644514
 ] 

ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------

cole-bq commented on code in PR #1883:
URL: https://github.com/apache/tinkerpop/pull/1883#discussion_r1042685776


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js:
##########
@@ -24,6 +24,8 @@
 'use strict';
 
 const crypto = require('crypto');
+const os = require('os');
+const gremlinVersion = require(__dirname + '/../package.json').version;

Review Comment:
   I tried using webpack to package and minimize a test client app and the 
driver version was still being correctly loaded into the user agent without 
issue.





> User agent for Gremlin drivers
> ------------------------------
>
>                 Key: TINKERPOP-2480
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver, server
>    Affects Versions: 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of 
> clients connecting to it. This issue is to add a new feature to add user 
> agent field in the HTTP and WebSocket request header which could be used to 
> identify the specific client from which the request was made.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to