[
https://issues.apache.org/jira/browse/TINKERPOP-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648675#comment-17648675
] ASF GitHub Bot commented on TINKERPOP-2837: ------------------------------------------- codecov-commenter commented on PR #1908: URL: https://github.com/apache/tinkerpop/pull/1908#issuecomment-1355024445 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1908](https://codecov.io/gh/apache/tinkerpop/pull/1908?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e140eea) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/341793e9da19b1474dd2c39982907cb2fbac574d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (341793e) will **decrease** coverage by `5.59%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1908 +/- ## ============================================= - Coverage 69.32% 63.72% -5.60% ============================================= Files 865 24 -841 Lines 41037 3664 -37373 Branches 5407 0 -5407 ============================================= - Hits 28450 2335 -26115 + Misses 10667 1149 -9518 + Partials 1920 180 -1740 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...emlin/process/traversal/util/ImmutableMetrics.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0ltbXV0YWJsZU1ldHJpY3MuamF2YQ==) | | | | [...gremlin/driver/handler/WebSocketClientHandler.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9oYW5kbGVyL1dlYlNvY2tldENsaWVudEhhbmRsZXIuamF2YQ==) | | | | [...mlin/process/traversal/step/filter/FilterStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL2ZpbHRlci9GaWx0ZXJTdGVwLmphdmE=) | | | | [...mlin/structure/util/empty/EmptyVertexProperty.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9lbXB0eS9FbXB0eVZlcnRleFByb3BlcnR5LmphdmE=) | | | | [.../strategy/optimization/MatchPredicateStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9vcHRpbWl6YXRpb24vTWF0Y2hQcmVkaWNhdGVTdHJhdGVneS5qYXZh) | | | | [.../gremlin/process/traversal/step/PathProcessor.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL1BhdGhQcm9jZXNzb3IuamF2YQ==) | | | | [...pop/gremlin/driver/ser/SerializationException.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9zZXIvU2VyaWFsaXphdGlvbkV4Y2VwdGlvbi5qYXZh) | | | | [...emlin/language/grammar/TraversalMethodVisitor.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL1RyYXZlcnNhbE1ldGhvZFZpc2l0b3IuamF2YQ==) | | | | [.../apache/tinkerpop/gremlin/structure/io/Mapper.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vTWFwcGVyLmphdmE=) | | | | [...emlin/process/traversal/step/map/ConstantStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9Db25zdGFudFN0ZXAuamF2YQ==) | | | | ... and [831 more](https://codecov.io/gh/apache/tinkerpop/pull/1908/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Thread-safe problem when using Collections.synchronizedMap in ImmutableMetrics > ------------------------------------------------------------------------------ > > Key: TINKERPOP-2837 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2837 > Project: TinkerPop > Issue Type: Bug > Components: language > Affects Versions: 3.5.4 > Reporter: Redriver > Priority: Major > > When I run the profile() in SparkGraphComputer, I got NPE: > > g.V().hasLabel('Account').has('Source', 10).has('AccountId', > '1000017194').as('sourceAccount').match( > __.as('sourceAccount').outE().inV().hasLabel('phone').as('node1'), > __.as('sourceAccount').outE().inV().hasLabel('name').as('node2'), > __.as('node1').inE().outV().hasLabel('Account').as('targetAccount'), > __.as('targetAccount').outE().inV().as('node2'), where('targetAccount', > neq('sourceAccount'))).select('targetAccount').valueMap().profile(） > > 22/12/07 02:21:00.980 dag-scheduler-event-loop ERROR DAGScheduler: Failed to > update accumulator 17 (org.apache.spark.util.LegacyAccumulatorWrapper) for > task 188 > java.lang.NullPointerException > at > java.util.Collections$SynchronizedMap.entrySet(Collections.java:2613) > at > org.apache.tinkerpop.gremlin.process.traversal.util.MutableMetrics.aggregate(MutableMetrics.java:139) > at > org.apache.tinkerpop.gremlin.process.traversal.step.util.ProfileStep$ProfileBiOperator.apply(ProfileStep.java:136) > at > org.apache.tinkerpop.gremlin.process.traversal.step.util.ProfileStep$ProfileBiOperator.apply(ProfileStep.java:130) > at > org.apache.tinkerpop.gremlin.spark.process.computer.MemoryAccumulator.addAccumulator(MemoryAccumulator.java:43) > at > org.apache.tinkerpop.gremlin.spark.process.computer.MemoryAccumulator.addInPlace(MemoryAccumulator.java:48) > at > org.apache.tinkerpop.gremlin.spark.process.computer.MemoryAccumulator.addInPlace(MemoryAccumulator.java:29) > at > org.apache.spark.util.LegacyAccumulatorWrapper.merge(AccumulatorV2.scala:512) > at > org.apache.spark.scheduler.DAGScheduler$$anonfun$updateAccumulators$1.apply(DAGScheduler.scala:1255) > at > org.apache.spark.scheduler.DAGScheduler$$anonfun$updateAccumulators$1.apply(DAGScheduler.scala:1246) > at > scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) > at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) > at > org.apache.spark.scheduler.DAGScheduler.updateAccumulators(DAGScheduler.scala:1246) > at > org.apache.spark.scheduler.DAGScheduler.handleTaskCompletion(DAGScheduler.scala:1341) > at > org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:2105) > at > org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2057) > at > org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2046) > at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:49) -- This message was sent by Atlassian Jira (v8.20.10#820010)
