[
https://issues.apache.org/jira/browse/TINKERPOP-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684148#comment-17684148
] ASF GitHub Bot commented on TINKERPOP-2864: ------------------------------------------- codecov-commenter commented on PR #1961: URL: https://github.com/apache/tinkerpop/pull/1961#issuecomment-1416725910 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1961](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (555227d) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/341793e9da19b1474dd2c39982907cb2fbac574d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (341793e) will **decrease** coverage by `5.13%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1961 +/- ## ============================================= - Coverage 69.32% 64.19% -5.13% ============================================= Files 865 24 -841 Lines 41037 3743 -37294 Branches 5407 0 -5407 ============================================= - Hits 28450 2403 -26047 + Misses 10667 1163 -9504 + Partials 1920 177 -1743 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [gremlin-go/driver/request.go](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVxdWVzdC5nbw==) | `78.89% <0.00%> (-5.87%)` | :arrow_down: | | [...gremlin/structure/io/binary/GraphBinaryWriter.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L0dyYXBoQmluYXJ5V3JpdGVyLmphdmE=) | | | | [...in/structure/io/binary/TypeSerializerRegistry.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L1R5cGVTZXJpYWxpemVyUmVnaXN0cnkuamF2YQ==) | | | | [...mlin/structure/io/binary/types/DateSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0RhdGVTZXJpYWxpemVyLmphdmE=) | | | | [...strategy/optimization/TinkerGraphStepStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy90cmF2ZXJzYWwvc3RyYXRlZ3kvb3B0aW1pemF0aW9uL1RpbmtlckdyYXBoU3RlcFN0cmF0ZWd5LmphdmE=) | | | | [...p/gremlin/server/channel/WsAndHttpChannelizer.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9jaGFubmVsL1dzQW5kSHR0cENoYW5uZWxpemVyLmphdmE=) | | | | [...ocess/traversal/step/sideEffect/SackValueStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3NpZGVFZmZlY3QvU2Fja1ZhbHVlU3RlcC5qYXZh) | | | | [...vy/jsr223/customizer/SimpleSandboxExtension.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vZ3Jvb3Z5L2pzcjIyMy9jdXN0b21pemVyL1NpbXBsZVNhbmRib3hFeHRlbnNpb24uZ3Jvb3Z5) | | | | [...emlin/process/traversal/lambda/TokenTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvVG9rZW5UcmF2ZXJzYWwuamF2YQ==) | | | | [...apache/tinkerpop/gremlin/structure/io/Storage.java](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vU3RvcmFnZS5qYXZh) | | | | ... and [834 more](https://codecov.io/gh/apache/tinkerpop/pull/1961?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > GraphBinaryMessageSerializer cannot serialize DefaultComputerResult > ------------------------------------------------------------------- > > Key: TINKERPOP-2864 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2864 > Project: TinkerPop > Issue Type: Bug > Components: driver > Affects Versions: 3.5.5 > Reporter: Redriver > Priority: Major > > When I send the following request to gremlin-server, I got an error > "{color:#1d1c1d}Serializer for type > org.apache.tinkerpop.gremlin.process.computer.util.DefaultComputerResult not > found{color}". > {code:java} > graph = GraphFactory.open('conf/fdb-psave-export.properties') > graph.compute(SparkGraphComputer).program(CloneVertexProgram.build().create()).submit().get() > {code} > After investigation, I found GraphBinaryMessageSerializer cannot serialize > DefaultComputerResult. The quick workaround is change the gremline to > {code:java} > graph = GraphFactory.open('conf/fdb-psave-export.properties') > a= > graph.compute(SparkGraphComputer).program(CloneVertexProgram.build().create()).submit().get() > a.toString() > {code} > This asks the GraphBinaryMessageSerializer to serialize String instead of > DefaultComputerGraph. > I'm wondering is it possible to change the GraphBinaryMessageSerializer to > automatically handle this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
