[
https://issues.apache.org/jira/browse/TINKERPOP-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689932#comment-17689932
]
ASF GitHub Bot commented on TINKERPOP-2824:
-------------------------------------------
spmallette commented on code in PR #1843:
URL: https://github.com/apache/tinkerpop/pull/1843#discussion_r1108919213
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -162,7 +168,10 @@ public class GremlinScriptChecker {
* </pre>
*/
private static final Pattern patternWithOptions =
- Pattern.compile("\\.with\\(((?:" + timeoutTokens +
"),(?<to>\\d*)(:?L|l)?)|((?:" + requestIdTokens +
"),[\"'](?<rid>.*?))[\"']\\)");
+ Pattern.compile("\\.with\\((((?:"
Review Comment:
every time i touch this, i've double checked to make sure there is no
significant performance penalty. this checker is executed a lot so we'd want to
know if a slow down was happening here. could you just validate that there is
no significant change with a quick benchmark? i don't expect anything given
what i recall from the last update here, but i think it's worth continuing to
validate assumptions on this one. maybe even make this a permanent benchmark in
gremlin-benchmarks so that we dont have to start from scratch each time?
> Properties on Elements
> ----------------------
>
> Key: TINKERPOP-2824
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2824
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, driver, go, javascript, process, python
> Affects Versions: 3.5.4
> Reporter: Valentyn Kahamlyk
> Assignee: Valentyn Kahamlyk
> Priority: Major
>
> Problem: When a user writes `g.V()` they get back a Vertex object. The
> problem is that depending on the execution context of the traversal, the
> result could be quite different, with or without properties.
> Solution: Implement new finalization strategy DetachStrategy(detachMode,
> properties) where mode is one of ALL, NONE or CUSTOM. `properties` is list of
> properties name, are taken into account only for CUSTOM mode.
> Discussion thread in dev list: [Proposal to handle properties on response
> Elements-Apache Mail
> Archives|https://lists.apache.org/thread/l8rw7ydj7kym8vhtwk50nhbp45ng9986]
> Stephen's thread in dev list: [The Issue of Detachment-Apache Mail
> Archives|https://lists.apache.org/thread/xltcon4zxnwq4fyw2r2126syyrqm8spy]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
