[ 
https://issues.apache.org/jira/browse/TINKERPOP-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690666#comment-17690666
 ] 

ASF GitHub Bot commented on TINKERPOP-2824:
-------------------------------------------

vkagamlyk commented on PR #1843:
URL: https://github.com/apache/tinkerpop/pull/1843#issuecomment-1435427556

   > Great change! I just added a few comments but basically all of them are 
only nitpicks.
   > 
   > Apart from that, I don't see any documentation for this new functionality. 
I think this needs to be documented in a lot of places (upgrade docs, 
changelog, reference docs, I/O docs). We should also definitely document that 
this changes the default behavior which will now include properties for all 
returned vertices and edges.
   > 
   > Do you want to do that in a follow-up PR?
   
   I plan to add documentation update to this PR, I first wanted the PR to be 
more or less formed




> Properties on Elements
> ----------------------
>
>                 Key: TINKERPOP-2824
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2824
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet, driver, go, javascript, process, python
>    Affects Versions: 3.5.4
>            Reporter: Valentyn Kahamlyk
>            Assignee: Valentyn Kahamlyk
>            Priority: Major
>
> Problem: When a user writes `g.V()` they get back a Vertex object. The 
> problem is that depending on the execution context of the traversal, the 
> result could be quite different, with or without properties.
> Solution: Implement new finalization strategy DetachStrategy(detachMode, 
> properties) where mode is one of ALL, NONE or CUSTOM. `properties` is list of 
> properties name, are taken into account only for CUSTOM mode.
> Discussion thread in dev list: [Proposal to handle properties on response 
> Elements-Apache Mail 
> Archives|https://lists.apache.org/thread/l8rw7ydj7kym8vhtwk50nhbp45ng9986]
> Stephen's thread in dev list: [The Issue of Detachment-Apache Mail 
> Archives|https://lists.apache.org/thread/xltcon4zxnwq4fyw2r2126syyrqm8spy]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to