[
https://issues.apache.org/jira/browse/TINKERPOP-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700821#comment-17700821
]
ASF GitHub Bot commented on TINKERPOP-2824:
-------------------------------------------
codecov-commenter commented on PR #1992:
URL: https://github.com/apache/tinkerpop/pull/1992#issuecomment-1470607251
##
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1992](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a466272) into
[master](https://codecov.io/gh/apache/tinkerpop/commit/1b667b6e25fb32e98d33f8d902ab2303a69030aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1b667b6) will **increase** coverage by `0.44%`.
> The diff coverage is `69.36%`.
```diff
@@ Coverage Diff @@
## master #1992 +/- ##
============================================
+ Coverage 68.55% 69.00% +0.44%
- Complexity 9091 9107 +16
============================================
Files 855 830 -25
Lines 41276 37556 -3720
Branches 5603 5625 +22
============================================
- Hits 28298 25914 -2384
+ Misses 11005 9819 -1186
+ Partials 1973 1823 -150
```
| [Impacted
Files](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...he/tinkerpop/gremlin/structure/VertexProperty.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvVmVydGV4UHJvcGVydHkuamF2YQ==)
| `40.00% <0.00%> (ø)` | |
|
[.../gremlin/driver/remote/DriverRemoteConnection.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9yZW1vdGUvRHJpdmVyUmVtb3RlQ29ubmVjdGlvbi5qYXZh)
| `47.91% <0.00%> (-1.02%)` | :arrow_down: |
|
[...p/gremlin/neo4j/structure/Neo4jVertexProperty.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovc3RydWN0dXJlL05lbzRqVmVydGV4UHJvcGVydHkuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...lin/server/handler/HttpGremlinEndpointHandler.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL0h0dHBHcmVtbGluRW5kcG9pbnRIYW5kbGVyLmphdmE=)
| `40.66% <27.27%> (-1.48%)` | :arrow_down: |
|
[...a/org/apache/tinkerpop/gremlin/server/Context.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9Db250ZXh0LmphdmE=)
| `74.19% <50.00%> (-8.91%)` | :arrow_down: |
|
[...pache/tinkerpop/gremlin/driver/RequestOptions.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9SZXF1ZXN0T3B0aW9ucy5qYXZh)
| `76.47% <60.00%> (-1.80%)` | :arrow_down: |
|
[...in/structure/io/binary/types/VertexSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL1ZlcnRleFNlcmlhbGl6ZXIuamF2YQ==)
| `84.61% <75.00%> (-15.39%)` | :arrow_down: |
|
[...mlin/structure/io/binary/types/EdgeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0VkZ2VTZXJpYWxpemVyLmphdmE=)
| `91.30% <80.00%> (-8.70%)` | :arrow_down: |
|
[.../gremlin/structure/util/detached/DetachedEdge.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9kZXRhY2hlZC9EZXRhY2hlZEVkZ2UuamF2YQ==)
| `87.93% <81.81%> (-1.44%)` | :arrow_down: |
|
[...tructure/util/detached/DetachedVertexProperty.java](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9kZXRhY2hlZC9EZXRhY2hlZFZlcnRleFByb3BlcnR5LmphdmE=)
| `94.44% <85.71%> (-1.56%)` | :arrow_down: |
| ... and [7
more](https://codecov.io/gh/apache/tinkerpop/pull/1992?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
... and [41 files with indirect coverage
changes](https://codecov.io/gh/apache/tinkerpop/pull/1992/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Properties on Elements
> ----------------------
>
> Key: TINKERPOP-2824
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2824
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, driver, go, javascript, process, python
> Affects Versions: 3.5.4
> Reporter: Valentyn Kahamlyk
> Assignee: Valentyn Kahamlyk
> Priority: Major
> Labels: breaking
>
> Problem: When a user writes `g.V()` they get back a Vertex object. The
> problem is that depending on the execution context of the traversal, the
> result could be quite different, with or without properties.
> Solution: Implement new finalization strategy DetachStrategy(detachMode,
> properties) where mode is one of ALL, NONE or CUSTOM. `properties` is list of
> properties name, are taken into account only for CUSTOM mode.
> Discussion thread in dev list: [Proposal to handle properties on response
> Elements-Apache Mail
> Archives|https://lists.apache.org/thread/l8rw7ydj7kym8vhtwk50nhbp45ng9986]
> Stephen's thread in dev list: [The Issue of Detachment-Apache Mail
> Archives|https://lists.apache.org/thread/xltcon4zxnwq4fyw2r2126syyrqm8spy]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
