[
https://issues.apache.org/jira/browse/TINKERPOP-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700873#comment-17700873
]
ASF GitHub Bot commented on TINKERPOP-2373:
-------------------------------------------
kenhuuu commented on code in PR #1986:
URL: https://github.com/apache/tinkerpop/pull/1986#discussion_r1137814776
##########
gremlin-console/src/main/static/NOTICE:
##########
@@ -18,15 +18,10 @@ Original source copyright:
Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
------------------------------------------------------------------------
-Apache Groovy 2.5.15 (AL ASF)
+Apache Groovy 4.0.9 (AL ASF)
------------------------------------------------------------------------
-This product includes/uses ANTLR (http://www.antlr2.org/)
-developed by Terence Parr 1989-2006
-
-This product bundles icons from the famfamfam.com silk icons set
-http://www.famfamfam.com/lab/icons/silk/
Review Comment:
> The NOTICE file for groovy seems to have even more contents now:
https://github.com/apache/groovy/blob/GROOVY_4_0_9/NOTICE
>
> not sure what's actually packaged in the groovy jars though.
I went through every groovy 4.0.9 jar included in our distribution and uber
jars and they don't contain any more information than what I included in this
PR. But, as I mentioned above, it is possible that they aren't packaging the
NOTICE files in META-INF anymore so it might be better to just add everything
from the NOTICE file you linked?
> Bump to Groovy 3.0
> ------------------
>
> Key: TINKERPOP-2373
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2373
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Priority: Major
>
> Groovy 3.0 has been out for a while now and has done several patch releases.
> Time to upgrade on 3.5.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
