[
https://issues.apache.org/jira/browse/TINKERPOP-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706474#comment-17706474
]
ASF GitHub Bot commented on TINKERPOP-2918:
-------------------------------------------
codecov-commenter commented on PR #2005:
URL: https://github.com/apache/tinkerpop/pull/2005#issuecomment-1488846222
##
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2005?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#2005](https://codecov.io/gh/apache/tinkerpop/pull/2005?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(03196ec) into
[master](https://codecov.io/gh/apache/tinkerpop/commit/4f1595604bc3da21ba84b65ecba293c3cc209914?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4f15956) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2005 +/- ##
============================================
- Coverage 69.32% 64.43% -4.90%
============================================
Files 878 25 -853
Lines 42042 3821 -38221
Branches 5629 0 -5629
============================================
- Hits 29147 2462 -26685
+ Misses 10902 1187 -9715
+ Partials 1993 172 -1821
```
[see 861 files with indirect coverage
changes](https://codecov.io/gh/apache/tinkerpop/pull/2005/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Utils.GenerateUserAgent assumes Gremlin.Net.dll to be present when, in some
> environments, it is not.
> ----------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2918
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2918
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.6.2
> Reporter: Daniel C. Weber
> Priority: Blocker
>
> The dotnet driver in v3.6.2 adds the ability to add a user agent to the
> request.
> To get the user agent name, Gremlin.Net.Process.Utils.GenerateUserAgent uses
> AssemblyName.GetAssemblyName("Gremlin.Net.dll") (see
> [here|https://github.com/apache/tinkerpop/blob/125e5bf4560546c9727dd25ff4d590f34c7d625b/gremlin-dotnet/src/Gremlin.Net/Process/Utils.cs#L81])
> Because the dll is referenced in a relative manner, in some environments
> (Visual studio debugging and Docker deployment for me), this results in a
> FileNotFoundException. In my specific local case, the path prefixed is the
> path where the csproj is.
> However, it works in a different project (also VS locally). I have no idea
> yet why. Also, I would file a pull request that would just use
> GetExecutingAssembly() instead of AssemblyName.GetAssemblyName (because the
> executing code is in that specific dll), but there's probably a reason for it
> not being used. Then again, using GetExecutingAssembly for the application
> name seems odd, was that supposed to be GetEntryAssembly?
> Will happily provide more insight and code.
> cc: [~Florian Hockmann]
> Edit: Proposed change in https://github.com/apache/tinkerpop/pull/2005
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
