[
https://issues.apache.org/jira/browse/TINKERPOP-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710944#comment-17710944
]
ASF GitHub Bot commented on TINKERPOP-2911:
-------------------------------------------
codecov-commenter commented on PR #2016:
URL: https://github.com/apache/tinkerpop/pull/2016#issuecomment-1503328884
##
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2016?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#2016](https://codecov.io/gh/apache/tinkerpop/pull/2016?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(39e3a74) into
[3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/fece764c460be08fb7ce72d63c49244ab6683d1b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(fece764) will **decrease** coverage by `5.18%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2016 +/- ##
=============================================
- Coverage 69.33% 64.16% -5.18%
=============================================
Files 866 25 -841
Lines 41219 3750 -37469
Branches 5432 0 -5432
=============================================
- Hits 28580 2406 -26174
+ Misses 10728 1166 -9562
+ Partials 1911 178 -1733
```
[see 841 files with indirect coverage
changes](https://codecov.io/gh/apache/tinkerpop/pull/2016/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> CountStrategy converts count().is(0) wrongly under ConnectiveStrategy
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2911
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2911
> Project: TinkerPop
> Issue Type: Bug
> Components: process, test-suite
> Affects Versions: 3.4.13, 3.6.2, 3.5.5
> Reporter: Norio Akagi
> Priority: Critical
>
> A query example:
> {noformat}
> // 2nd branch is just a dummy, and assuming we don't have an edge with label
> "none"
> g.V().where(or(out("none").out().count().is(0), has("none"))) {noformat}
> Here, CountStrategy tries to convert {{count().is(0)}} to {{not(...).}}
> However, when it is under ConnectiveStrategy, it tries to read Steps from
> tail to beginning and include Steps until it finds the first non-filter Step.
> So in this case, it becomes
> {noformat}
> [GraphStep(vertex,[]), OrStep([[VertexStep(OUT,[none],vertex),
> NotStep([VertexStep(OUT,edge)])],
> [TraversalFilterStep([NeptunePropertiesStep([none],property)])]])]{noformat}
> So the first out("none") is outside of NotStep, whereas the 2nd out() is
> inside.
> The original intention of this query is that the 1st branch under {{or}}
> should return {{true}} in the first branch, because there is no such edge
> with the label {{"none"}} and {{{}count = 0{}}}.
> However this optimization returns the opposite result. Because the first
> {{VertexStep(OUT,[none],vertex)}} is now outside of {{{}NotStep{}}}, the 1st
> branch returns {{{}false{}}}.
> It seems this logic was intentionally introduced while back ago
> [https://github.com/apache/tinkerpop/commit/36bd2a2447529371d950b2df6de36ea49957ab55]
> So just reverting this change may not be the permanent fix. We should
> investigate what should be the correct behavior for CountStrategy to apply
> under ConnectivityStep.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
