[
https://issues.apache.org/jira/browse/TINKERPOP-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712399#comment-17712399
]
ASF GitHub Bot commented on TINKERPOP-2924:
-------------------------------------------
codecov-commenter commented on PR #2022:
URL: https://github.com/apache/tinkerpop/pull/2022#issuecomment-1508571558
##
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#2022](https://codecov.io/gh/apache/tinkerpop/pull/2022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(56cc34f) into
[3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/aa44bc31fe87d1be7c5c46fcf9e3a5ef50367dc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(aa44bc3) will **increase** coverage by `0.06%`.
> The diff coverage is `87.50%`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2022 +/- ##
=============================================
+ Coverage 69.36% 69.42% +0.06%
- Complexity 9329 9345 +16
=============================================
Files 878 878
Lines 42083 42095 +12
Branches 5640 5641 +1
=============================================
+ Hits 29189 29225 +36
+ Misses 10901 10878 -23
+ Partials 1993 1992 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/tinkerpop/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...in/process/traversal/step/map/PropertyMapStep.java](https://codecov.io/gh/apache/tinkerpop/pull/2022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9Qcm9wZXJ0eU1hcFN0ZXAuamF2YQ==)
| `89.24% <87.50%> (-1.12%)` | :arrow_down: |
... and [9 files with indirect coverage
changes](https://codecov.io/gh/apache/tinkerpop/pull/2022/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Refactor PropertyMapStep to be able to overwrite map method
> -----------------------------------------------------------
>
> Key: TINKERPOP-2924
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2924
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.6.2
> Reporter: Oleksandr Porunov
> Priority: Minor
>
> We would like to extend `PropertyMapStep` and overwrite some of it's
> functionality (in `map` method), so that we could leverage multi-query
> optimization in JanusGraph for `PropertyMapStep`.
> Unfortunately, some of it's utility methods and fields are `private`. Thus,
> we should duplicate `includeToken` logic and we don't have any access to
> `traversalRing` because it's private and is created inside the constructor.
> I would suggest making all of those private fields / methods as protected
> (similarly as it's done in `PropertiesStep`), so that there would be a
> possibility for overwrite without logic duplication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
