[
https://issues.apache.org/jira/browse/TINKERPOP-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713722#comment-17713722
] ASF GitHub Bot commented on TINKERPOP-2855: ------------------------------------------- codecov-commenter commented on PR #2026: URL: https://github.com/apache/tinkerpop/pull/2026#issuecomment-1513660499 ## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2026](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18067b2) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b77a0166be7198a80dc7f7dd775d3342284daf76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b77a016) will **decrease** coverage by `0.04%`. > The diff coverage is `82.14%`. ```diff @@ Coverage Diff @@ ## 3.5-dev #2026 +/- ## ============================================= - Coverage 69.36% 69.32% -0.04% + Complexity 8962 8956 -6 ============================================= Files 866 866 Lines 41227 41229 +2 Branches 5434 5434 ============================================= - Hits 28598 28583 -15 - Misses 10714 10736 +22 + Partials 1915 1910 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...cess/remote/traversal/AbstractRemoteTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3JlbW90ZS90cmF2ZXJzYWwvQWJzdHJhY3RSZW1vdGVUcmF2ZXJzYWwuamF2YQ==) | `5.26% <0.00%> (-0.30%)` | :arrow_down: | | [...tinkerpop/gremlin/process/traversal/Traversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9UcmF2ZXJzYWwuamF2YQ==) | `76.74% <ø> (ø)` | | | [...gremlin/process/traversal/util/EmptyTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0VtcHR5VHJhdmVyc2FsLmphdmE=) | `37.50% <0.00%> (-1.21%)` | :arrow_down: | | [...emlin/process/traversal/util/DefaultTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0RlZmF1bHRUcmF2ZXJzYWwuamF2YQ==) | `84.61% <84.21%> (+0.12%)` | :arrow_up: | | [...cess/traversal/lambda/AbstractLambdaTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvQWJzdHJhY3RMYW1iZGFUcmF2ZXJzYWwuamF2YQ==) | `59.64% <100.00%> (-13.08%)` | :arrow_down: | | [...aversal/strategy/decoration/PartitionStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9kZWNvcmF0aW9uL1BhcnRpdGlvblN0cmF0ZWd5LmphdmE=) | `83.23% <100.00%> (ø)` | | | [...remlin/process/traversal/util/TraversalHelper.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL1RyYXZlcnNhbEhlbHBlci5qYXZh) | `85.60% <100.00%> (+0.11%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2026/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Performance degradation in TinkerGraph 3.5.4 and 3.5.5 > ------------------------------------------------------ > > Key: TINKERPOP-2855 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2855 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph > Affects Versions: 3.5.4, 3.5.5 > Environment: Ubuntu 22.04.1, docker > Reporter: Gleb Sinyavskiy > Priority: Critical > Labels: bug, performance > > Hello, > I few days ago I tried to update gremlin-server in our project from 3.5.3 to > 3.5.4 and found out that it's test suite got 5 times slower. We use the > official docker image(tinkerpop/gremlin-server) with some configuration > changes: > {code:java} > gremlin.tinkergraph.vertexIdManager=ANY > gremlin.tinkergraph.edgeIdManager=ANY {code} > The app uses user-generated string ids and heavily relies on the upsert > pattern from the [recipes|https://tinkerpop.apache.org/docs/3.5.4/recipes/]. > Yesterday I made an investigation and narrowed it down to the performance of > the upsert pattern. I also discovered that the issue is not related to our > configuration changes and can be reproduced with vanilla image and LONG ids. > I prepared a [simple script that reproduces the > issue|https://github.com/zhulik/gremlin-server-performance-issue/] and > contacted Stephen Mallette on discord. They confirmed the issue exists, but > only in 3.5.4, 3.6.0 performs as expected. They also wrote a groovy script > that reproduces the problem: > {code:groovy} > g = TinkerGraph.open().traversal() > batches = (0..<100).collect{ (0..<100) } > start = System.currentTimeMillis() > for (batch in batches) { > b = g > for (id in batch) { > b = b.V(id).fold().coalesce(__.unfold(), __.addV("test").property(T.id, > id)) > } > b.iterate() > } > System.currentTimeMillis() - start > {code} > [discord > message|https://discord.com/channels/838910279550238720/838910279550238723/1064964247823593502] > Both my and Stephen's scripts perform a few times slower when executed > against 3.5.4 in compare to 3.5.3 or 3.6.0. > *Steps to reproduce:* > Run my or Stephen's script against vanilla tinkerpop/gremlin-server:3.5.4 > docker image > *Expected result:* > Script's execution time matches it's time when executed against 3.5.3 or 3.6.0 > *Observed result:* > The script is 5-7 times slower. -- This message was sent by Atlassian Jira (v8.20.10#820010)
