[ 
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714420#comment-17714420
 ] 

ASF GitHub Bot commented on TINKERPOP-2925:
-------------------------------------------

xiazcy opened a new pull request, #2034:
URL: https://github.com/apache/tinkerpop/pull/2034

   https://issues.apache.org/jira/browse/TINKERPOP-2925
   
   Issue in gremlin-javascript arose due to Direction aliases `from_` and `to` 
not properly returning `Direction.OUT` and `Direction.IN`.
   
   Also found similar issue in gremlin-python, where `Direction.from_` and 
`Direction.to` were not added to the `Direction` enum. They can now be used 
directly without the need to declare `from_ = Direction.OUT` and `to = 
Direction.IN`.
   
   The existing Gherkin test as 
`g_mergeEXlabel_knows_out_marko_in_vadasX_aliased_direction` covers the case, 
although customized alias maps in feature-steps masked the issue in python and 
javascript, which are now removed.
   
   This issue doesn't seem to appear in gremlin-go and gremlin-dotnet. 
   




> mergeE() in javascript producing an error
> -----------------------------------------
>
>                 Key: TINKERPOP-2925
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: javascript
>    Affects Versions: 3.6.2
>            Reporter: Stephen Mallette
>            Priority: Blocker
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from): 
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds 
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the 
> client-side error for this. it may have been a bit opaque.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to