[
https://issues.apache.org/jira/browse/TINKERPOP-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717109#comment-17717109
]
ASF GitHub Bot commented on TINKERPOP-2934:
-------------------------------------------
codecov-commenter commented on PR #2050:
URL: https://github.com/apache/tinkerpop/pull/2050#issuecomment-1525410168
##
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#2050](https://codecov.io/gh/apache/tinkerpop/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(d008250) into
[3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b8d91efb45ed41d1cd4cd11a7f6e795b5c68a244?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b8d91ef) will **decrease** coverage by `5.45%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2050 +/- ##
=============================================
- Coverage 69.88% 64.43% -5.45%
=============================================
Files 841 25 -816
Lines 37412 3821 -33591
Branches 5418 0 -5418
=============================================
- Hits 26144 2462 -23682
+ Misses 9532 1187 -8345
+ Partials 1736 172 -1564
```
[see 866 files with indirect coverage
changes](https://codecov.io/gh/apache/tinkerpop/pull/2050/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Optimize ObjectWritable for displaying content of Java Collection or Map to
> reduce OOM
> --------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2934
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2934
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.6.2
> Reporter: Redriver
> Priority: Major
> Attachments: image-2023-04-27-15-08-10-874.png
>
>
> OLAP query easily triggers OOM, I found a possible reason is
> [https://github.com/apache/tinkerpop/blob/master/hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/ObjectWritable.java#L72]
> dump a huge string output. See what I captureed from SparkUI. In fact, that
> toString() does not make much sense for OLAP processing except for displaying
> in UI. Furthermore, those too long string is not readable for people. So,
> ideally the toString() for Map or Collection should be optimized to be java
> class + size(). Then the OOM will disappear.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
