[
https://issues.apache.org/jira/browse/TINKERPOP-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720647#comment-17720647
]
ASF GitHub Bot commented on TINKERPOP-2703:
-------------------------------------------
lyndonbauto commented on code in PR #2056:
URL: https://github.com/apache/tinkerpop/pull/2056#discussion_r1187780194
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java:
##########
@@ -103,9 +103,9 @@ public final class TinkerGraph implements Graph {
protected TinkerIndex<TinkerVertex> vertexIndex = null;
protected TinkerIndex<TinkerEdge> edgeIndex = null;
- protected final IdManager<?> vertexIdManager;
- protected final IdManager<?> edgeIdManager;
- protected final IdManager<?> vertexPropertyIdManager;
+ protected IdManager<?> vertexIdManager;
+ protected IdManager<?> edgeIdManager;
+ protected IdManager<?> vertexPropertyIdManager;
Review Comment:
Is the removal of `final` here required?
> Build on JDK17
> --------------
>
> Key: TINKERPOP-2703
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2703
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.5.2
> Reporter: Stephen Mallette
> Priority: Minor
>
> Upgrade the build to work with JDK17. This actually is a bit of an umbrella
> issue covering lots of different things in TinkerPop. Early examination of
> this issue shows that like the move to JDK11, the change is not trivial.
> Known issues so far:
> * Groovy 4.x upgrade brings some strange failures to the gmavenplus-plugin
> during GLV building
> * Kryo 3.x is not compliant with JDK17
> In addition, Please look at the related linked issues for more information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
