[ https://issues.apache.org/jira/browse/TINKERPOP-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720827#comment-17720827 ]
ASF GitHub Bot commented on TINKERPOP-2944: ------------------------------------------- codecov-commenter commented on PR #2058: URL: https://github.com/apache/tinkerpop/pull/2058#issuecomment-1539604114 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2058?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2058](https://app.codecov.io/gh/apache/tinkerpop/pull/2058?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27f7dbd) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/2ee47f203ffa76b9c0c466bd8ba291010afdd831?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ee47f2) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.5-dev #2058 +/- ## ========================================== Coverage 69.38% 69.39% + Complexity 8975 8974 -1 ========================================== Files 866 866 Lines 41251 41251 Branches 5442 5442 ========================================== + Hits 28621 28625 +4 + Misses 10719 10716 -3 + Partials 1911 1910 -1 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2058/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Memory leak in Gremlin.Net driver if CancellationToken is used > -------------------------------------------------------------- > > Key: TINKERPOP-2944 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2944 > Project: TinkerPop > Issue Type: Bug > Components: dotnet > Affects Versions: 3.6.2, 3.5.5, 3.6.3, 3.5.6 > Reporter: Florian Hockmann > Assignee: Florian Hockmann > Priority: Major > > We have noticed in my team at G DATA that a .NET service has been using an > increasing amount of memory since we began to propagate the > {{CancellationToken}} into the Gremlin.Net traversal executions which was > introduced in TINKERPOP-2794. > We could track this down with memory profiling to [this place in the > driver|https://github.com/apache/tinkerpop/blob/5c8af70c7fac3ee98df36d250b05320e67ff1b96/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L94] > where we register a callback to execute when cancellation is requested. > These registered callbacks are only cleaned up when the whole {{Connection}} > object gets disposed. Since the callback contains a reference to the full > {{RequestMessage}} of the traversal, it can contain a lot of data. This is > something that I've completely overlooked when I added support for > cancellation. > The driver should clean up those callbacks when they are not needed any more > because the request has been processed completely (either successfully or > with an error). -- This message was sent by Atlassian Jira (v8.20.10#820010)