[
https://issues.apache.org/jira/browse/TINKERPOP-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733384#comment-17733384
] ASF GitHub Bot commented on TINKERPOP-2672: ------------------------------------------- codecov-commenter commented on PR #2099: URL: https://github.com/apache/tinkerpop/pull/2099#issuecomment-1594276404 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2099](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8be3cda) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/f9d784771057dfa299ec0b43d0cadde5e2d95226?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f9d7847) will **decrease** coverage by `0.04%`. > The diff coverage is `80.53%`. ```diff @@ Coverage Diff @@ ## master #2099 +/- ## ============================================ - Coverage 74.85% 74.81% -0.04% - Complexity 11997 12027 +30 ============================================ Files 1025 1028 +3 Lines 62034 62147 +113 Branches 6849 6872 +23 ============================================ + Hits 46438 46498 +60 - Misses 13046 13102 +56 + Partials 2550 2547 -3 ``` | [Impacted Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/language/grammar/DefaultGremlinBaseVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0RlZmF1bHRHcmVtbGluQmFzZVZpc2l0b3IuamF2YQ==) | `0.27% <0.00%> (-0.01%)` | :arrow_down: | | [.../tinkerpop/gremlin/process/traversal/Operator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9PcGVyYXRvci5qYXZh) | `90.24% <ø> (ø)` | | | [gremlin-go/driver/anonymousTraversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvYW5vbnltb3VzVHJhdmVyc2FsLmdv) | `44.97% <0.00%> (-0.40%)` | :arrow_down: | | [...inkerpop/gremlin/process/ProcessStandardSuite.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi10ZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL1Byb2Nlc3NTdGFuZGFyZFN1aXRlLmphdmE=) | `66.66% <ø> (ø)` | | | [...kerpop/gremlin/process/traversal/dsl/graph/\_\_.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvX18uamF2YQ==) | `77.84% <50.00%> (-0.65%)` | :arrow_down: | | [...emlin/language/grammar/TraversalMethodVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL1RyYXZlcnNhbE1ldGhvZFZpc2l0b3IuamF2YQ==) | `91.20% <57.14%> (-0.80%)` | :arrow_down: | | [...n/process/traversal/step/map/ConcatGlobalStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9Db25jYXRHbG9iYWxTdGVwLmphdmE=) | `83.87% <83.87%> (ø)` | | | [...in/process/traversal/step/map/ConcatLocalStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9Db25jYXRMb2NhbFN0ZXAuamF2YQ==) | `84.37% <84.37%> (ø)` | | | [...in/process/traversal/dsl/graph/GraphTraversal.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `92.32% <100.00%> (-0.55%)` | :arrow_down: | | [...process/traversal/translator/DotNetTranslator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC90cmFuc2xhdG9yL0RvdE5ldFRyYW5zbGF0b3IuamF2YQ==) | `75.58% <100.00%> (+0.09%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/apache/tinkerpop/pull/2099?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2099/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > Add String Manipulation Steps to Gremlin > ---------------------------------------- > > Key: TINKERPOP-2672 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2672 > Project: TinkerPop > Issue Type: Improvement > Components: language > Reporter: Dave Bechberger > Priority: Major > > Today Gremlin requires that users fall back to closures to handle many common > string manipulation options that users want to do on data in the graph. This > is a problem for many users as many of the providers prevent the use of > closures due to the security risks so for these users there is no way to > manipulate strings directly. > The proposal here is to add a set of steps to handle common string > manipulation requests from users including: > * `concat(String)` - concatenates the String to the value of the traverser > * 'length()` - returns the length of the string > * `split(String)` - returns an array of strings based on the split char > passed in > * `substring(beginIndex, endIndex)` - returns a substring based on the start > and end index values passed in > * `substring(beginIndex)` - returns a substring beginning at the start index > * `rtrim()` - remove spaces at the beginning of a string > * `ltrim()` - remove spaces at the end of a string > * `trim()` - remove spaces at the beginning and end of a string > * `replace(old, new)` - replaces all occurences of the `old` string with the > `new` string > * `reverse()` - reverses the string > * `tostring()` - turns the incoming item into a string > * `toupper()` - upper cases the incoming string > * `tolower()` - lower cases the incoming string > > All the above functions except `tostring()` will throw an error if a > non-string value is passed in -- This message was sent by Atlassian Jira (v8.20.10#820010)
