[ https://issues.apache.org/jira/browse/TINKERPOP-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740739#comment-17740739 ]
ASF GitHub Bot commented on TINKERPOP-2965: ------------------------------------------- codecov-commenter commented on PR #2124: URL: https://github.com/apache/tinkerpop/pull/2124#issuecomment-1624088759 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2124](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9fc2637) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/1cca37e512ef0e186ab5ba1dfb1267c4288d4989?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1cca37e) will **increase** coverage by `0.02%`. > The diff coverage is `94.87%`. ```diff @@ Coverage Diff @@ ## 3.5-dev #2124 +/- ## ============================================= + Coverage 69.90% 69.92% +0.02% - Complexity 8979 8997 +18 ============================================= Files 865 866 +1 Lines 40967 41001 +34 Branches 5450 5455 +5 ============================================= + Hits 28636 28669 +33 + Misses 10425 10423 -2 - Partials 1906 1909 +3 ``` | [Impacted Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...remlin/process/traversal/util/DepthComparator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0RlcHRoQ29tcGFyYXRvci5qYXZh) | `80.00% <80.00%> (ø)` | | | [...l/strategy/optimization/FilterRankingStrategy.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9vcHRpbWl6YXRpb24vRmlsdGVyUmFua2luZ1N0cmF0ZWd5LmphdmE=) | `100.00% <100.00%> (ø)` | | | [...remlin/process/traversal/util/TraversalHelper.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL1RyYXZlcnNhbEhlbHBlci5qYXZh) | `86.22% <100.00%> (+0.62%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2124/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > FilterRankingStrategy removing labels it shouldn't in certain conditions > ------------------------------------------------------------------------ > > Key: TINKERPOP-2965 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2965 > Project: TinkerPop > Issue Type: Bug > Components: process > Affects Versions: 3.6.3 > Reporter: Stephen Mallette > Assignee: Stephen Mallette > Priority: Critical > > This traversal demonstrates it: > {code} > g.V().as('n').where( > __.or( > __.select('n').hasLabel('Tag'), > __.select('n').hasLabel('Person') > ) > ).select('n').project('n').by(__.valueMap().with('~tinkerpop.valueMap.tokens')) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)