[
https://issues.apache.org/jira/browse/TINKERPOP-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741752#comment-17741752
]
ASF GitHub Bot commented on TINKERPOP-2957:
-------------------------------------------
vkagamlyk commented on code in PR #2127:
URL: https://github.com/apache/tinkerpop/pull/2127#discussion_r1258788824
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -3286,6 +3307,29 @@ public default <M, E2> GraphTraversal<S, E> option(final
M token, final Map<Obje
return this;
}
+ /**
+ * This is a step modulator to a {@link TraversalOptionParent} like {@code
choose()} or {@code mergeV()} where the
+ * provided argument associated to the {@code token} is applied according
to the semantics of the step. Please see
+ * the documentation of such steps to understand the usage context.
+ *
+ * @param m Provides a {@code Map} as the option which is the same as
doing {@code constant(m)}.
+ * @return the traversal with the modulated step
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#mergev-step";
target="_blank">Reference Documentation - MergeV Step</a>
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#mergee-step";
target="_blank">Reference Documentation - MergeE Step</a>
+ * @since 3.6.0
Review Comment:
```suggestion
* @since 3.7.0
```
> mergeV with sideEffect not correctly updating properties
> --------------------------------------------------------
>
> Key: TINKERPOP-2957
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2957
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.6.4
> Reporter: Kelvin Lawrence
> Assignee: Stephen Mallette
> Priority: Blocker
>
> A Gremlin user let me know about the following issue. If the query below is
> run twice, the name parameter on the 4567 vertex does not get updated. The
> name on the 1234 vertex does get updated. The query is written this way as
> not all databases support single cardinality as the default. The issue has
> been reproduced using both TinkerGraph and Amazon Neptune.
> {code:java}
> g.mergeV([(T.id): 'test-test-1234']).
> option(onCreate, [(T.label): 'someLabel', 'name': 'name1']).
> option(onMatch, sideEffect(property(single,"name","name2")).constant([:])).
> mergeV([(T.id): 'test-test-4567']).
> option(onCreate, [(T.label): 'someLabel', 'name': 'name1']).
> option(onMatch,
> sideEffect(property(single,"name","name2")).constant([:])){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
