[
https://issues.apache.org/jira/browse/TINKERPOP-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742813#comment-17742813
]
ASF GitHub Bot commented on TINKERPOP-2949:
-------------------------------------------
spmallette commented on code in PR #2134:
URL: https://github.com/apache/tinkerpop/pull/2134#discussion_r1262568545
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/PBiPredicate.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.tinkerpop.gremlin.process.traversal;
+
+import java.util.function.BiPredicate;
+
+/**
+ * Marker interface for predefined {@code BiPredicate} predicates that can be
used in {@code Predicate}}.
Review Comment:
could you update the javadoc to say a few words about why this interface was
needed, what it helps to do, what problems it helps avoid, etc.?
> More strict handling of predicates
> ----------------------------------
>
> Key: TINKERPOP-2949
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2949
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.0
> Reporter: Valentyn Kahamlyk
> Priority: Critical
>
> P, TextP, ConnectiveP now accept arbitrary `biPredicate` as argument, which
> can lead to serialization problems. Introduce new interface over
> `biPredicate` to make predicate naming more strict
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
