[
https://issues.apache.org/jira/browse/TINKERPOP-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746676#comment-17746676
]
ASF GitHub Bot commented on TINKERPOP-2946:
-------------------------------------------
codecov-commenter commented on PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150#issuecomment-1648739117
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2150](https://app.codecov.io/gh/apache/tinkerpop/pull/2150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(cf83bc2) into
[master](https://app.codecov.io/gh/apache/tinkerpop/commit/127bf02c84618aed5777d115dfc8780aed17e55d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(127bf02) will **decrease** coverage by `5.57%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2150 +/- ##
============================================
- Coverage 75.85% 70.29% -5.57%
============================================
Files 1039 24 -1015
Lines 63433 3541 -59892
Branches 7028 0 -7028
============================================
- Hits 48120 2489 -45631
+ Misses 12694 881 -11813
+ Partials 2619 171 -2448
```
[see 1015 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2150/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
> Resolve ordering issues in gherkin tests
> ----------------------------------------
>
> Key: TINKERPOP-2946
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2946
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.6.2
> Reporter: Stephen Mallette
> Priority: Blocker
>
> Gremlin doesn't enforce order, yet many of the gherkin tests carry that
> expectation.
> 1. Develop a mechanism to ensure that tests don't come with that expectation.
> 2. Fix tests that have this assumption and improve test language and
> assertion logic as needed.
> One way to do (1) would be to provide a configuration to TinkerGraph that
> would make it behave more like most graph databases and purposefully
> randomize result streams. Perhaps this configuration could be used as part of
> a integration test to ensure a regular {{mvn clean install}} works
> deterministically?? Doing (1) should yield information on what needs to be
> done with (2). Some of (2) may be test fixes, but I think assertion logic
> around containers may need to be improved. When asserting a {{List}} result
> for example we often want to say that it contains "all items" rather than
> "all items in the specified order". We have that sort of gherkin language at
> the overall result level but not at the individual one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
