[
https://issues.apache.org/jira/browse/TINKERPOP-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747116#comment-17747116
]
ASF GitHub Bot commented on TINKERPOP-2938:
-------------------------------------------
codecov-commenter commented on PR #2158:
URL: https://github.com/apache/tinkerpop/pull/2158#issuecomment-1650376864
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2158](https://app.codecov.io/gh/apache/tinkerpop/pull/2158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(e6783ff) into
[3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/489e00b2a9c1f3c5272450b0639468a15941e158?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(489e00b) will **decrease** coverage by `5.11%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2158 +/- ##
=============================================
- Coverage 75.26% 70.16% -5.11%
=============================================
Files 1050 24 -1026
Lines 62856 3492 -59364
Branches 6887 0 -6887
=============================================
- Hits 47308 2450 -44858
+ Misses 13002 875 -12127
+ Partials 2546 167 -2379
```
[see 1027 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2158/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
> Revisit merge step feature tests
> --------------------------------
>
> Key: TINKERPOP-2938
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2938
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.6.2
> Reporter: Yang Xia
> Priority: Critical
>
> I've added a set of tests for
> [https://github.com/apache/tinkerpop/pull/2036,] with the CTR here
> [https://github.com/apache/tinkerpop/commit/2c9e5300d6901c72e565f89e50ab0e4844ccd56e].
>
> Ideally I want the Feature test to check that the exception fails with the
> intended error message, however, there seems to be a problem with the
> exception falling through when you have an empty graph and invalid maps to
> add just to g.V(['~label', vertex]). The intended errors appear to be null
> when you check with the step, but then gets printed after in the terminal
> output, which I wonder if it's not being caught in the toList() step, or if
> there is some race going on.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
