[
https://issues.apache.org/jira/browse/TINKERPOP-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747680#comment-17747680
]
ASF GitHub Bot commented on TINKERPOP-2939:
-------------------------------------------
codecov-commenter commented on PR #2162:
URL: https://github.com/apache/tinkerpop/pull/2162#issuecomment-1652656164
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2162](https://app.codecov.io/gh/apache/tinkerpop/pull/2162?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(e54dd78) into
[3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/a0d5c831ad2de72074e21b158182f4355791a05e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(a0d5c83) will **decrease** coverage by `4.96%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2162 +/- ##
=============================================
- Coverage 75.20% 70.24% -4.96%
=============================================
Files 1050 24 -1026
Lines 62856 3492 -59364
Branches 6887 0 -6887
=============================================
- Hits 47271 2453 -44818
+ Misses 13051 873 -12178
+ Partials 2534 166 -2368
```
[see 1026 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2162/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
> The Merge onMatch map validation is during execution instead of construction
> ----------------------------------------------------------------------------
>
> Key: TINKERPOP-2939
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2939
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.6.3
> Reporter: Yang Xia
> Priority: Critical
>
> A small thing I noticed related to TINKERPOP-2931.
> With an empty graph, the traversal
> {code:java}
> g.mergeV([:]).option(onMatch, ['~label', 'vertex']) {code}
> will create a new vertex, and since onMatch failed it doesn't apply anything
> inside regardless if it's a valid map or not, and will return
> {code:java}
> v[0]{code}
> This won't have any impact function-wise, since the onMatch map will be
> validated when the vertex is found, but just wondering if we should validate
> this on construction instead of execution?
> A more visual example on 3.6.3-SNAPSHOT console.
> {code:java}
> gremlin> g.mergeV([:]).option(Merge.onMatch, ['~label':'vertex'])
> ==>v[0]
> gremlin> g.mergeV([:]).option(Merge.onMatch, ['~label':'vertex'])
> Property key can not be a hidden key: ~label
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> gremlin> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
