[
https://issues.apache.org/jira/browse/TINKERPOP-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756568#comment-17756568
]
ASF GitHub Bot commented on TINKERPOP-2986:
-------------------------------------------
codecov-commenter commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1685354872
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2212](https://app.codecov.io/gh/apache/tinkerpop/pull/2212?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(946ddc3) into
[master](https://app.codecov.io/gh/apache/tinkerpop/commit/ce88ce1a8f576d5d2114154951bf009b7e0285a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(ce88ce1) will **increase** coverage by `0.84%`.
> Report is 1570 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2212 +/- ##
============================================
+ Coverage 69.91% 70.75% +0.84%
============================================
Files 866 24 -842
Lines 41068 3567 -37501
Branches 5476 0 -5476
============================================
- Hits 28713 2524 -26189
+ Misses 10455 875 -9580
+ Partials 1900 168 -1732
```
[see 854 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2212/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
> StarGraph shall drop edge properties when dropping edges
> --------------------------------------------------------
>
> Key: TINKERPOP-2986
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2986
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Boxuan Li
> Priority: Major
>
> SparkGraphComputer uses StarGraph and StarGraph::StarVertex to represent
> vertices and edges. The StarGraph::StarVertex::dropEdges method drops
> unneeded edges, but it doesn't drop their edge properties, which are stored
> in another data structure (StarGraph::edgeProperties).
> In my use case, I only need edges with a certain label - yet all edge
> properties are loaded and never get dropped. With my local fix, the memory
> footprint used by the Spark program drops by more than 90%.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
