[
https://issues.apache.org/jira/browse/TINKERPOP-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785097#comment-17785097
]
ASF GitHub Bot commented on TINKERPOP-3014:
-------------------------------------------
codecov-commenter commented on PR #2335:
URL: https://github.com/apache/tinkerpop/pull/2335#issuecomment-1806577456
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2335](https://app.codecov.io/gh/apache/tinkerpop/pull/2335?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(1b1d5e4) into
[master](https://app.codecov.io/gh/apache/tinkerpop/commit/670dc224bf72a40f4e4dea19b3cc77d529ade0e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(670dc22) will **decrease** coverage by `4.86%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2335 +/- ##
============================================
- Coverage 75.90% 71.05% -4.86%
============================================
Files 1082 25 -1057
Lines 64925 3942 -60983
Branches 7241 0 -7241
============================================
- Hits 49284 2801 -46483
+ Misses 12981 950 -12031
+ Partials 2660 191 -2469
```
[see 1057 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on
GitHub. Try it in
[Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo)
or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
> Dependencny jcl-over-slf4j in gremlin-core is declared but unused due to
> dependency conflict.
> ---------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-3014
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3014
> Project: TinkerPop
> Issue Type: Bug
> Reporter: Weijie Sun
> Priority: Major
> Labels: dependency
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> h2. Problem Description
> "gremlin-core" declares "jcl-over-slf4j" as its dependency. However, it seems
> that the dependency is actually unused due to a dependency conflict.
> There is another dependency "commons-logging:commons-logging" in the
> dependency tree as listed below:
> {code:java}
> org.apache.tinkerpop:gremlin-core:jar:3.7.0-SNAPSHOT
> \- org.apache.commons:commons-configuration2:jar:2.9.0:compile
> \- commons-logging:commons-logging:jar:1.2:compile
> \- org.slf4j:jcl-over-slf4j:jar:1.7.33:compile{code}
> The classes in "jcl-over-slf4j" are also in "commons-logging" as listed below:
> {code:java}
> [INFO] org.apache.commons.logging.impl.NoOpLog
> [INFO] org.apache.commons.logging.impl.SimpleLog$1
> [INFO] org.apache.commons.logging.impl.SimpleLog
> [INFO] org.apache.commons.logging.impl.SLF4JLocationAwareLog
> [INFO] org.apache.commons.logging.impl.SLF4JLog
> [INFO] org.apache.commons.logging.impl.SLF4JLogFactory
> [INFO] org.apache.commons.logging.Log
> [INFO] org.apache.commons.logging.LogConfigurationException
> [INFO] org.apache.commons.logging.LogFactory{code}
> The problem is that "commons-logging" is ahead of "jcl-over-slf4j" in the
> dependency tree, thus ahead of "jcl-over-slf4j" in the classpath. When
> multiple JAR files contain the same class, the class loader will load the
> first occurrence it finds based on the classpath order. This means the
> classloader will select classes in "commons-logging" instead of
> "jcl-over-slf4j".
> So despite "jcl-over-slf4j" being declared directly, it's actually unused.
> "commons-logging" is the actual used dependency, causing confusion.
> h2. Possible Solution
> Change the order of "jcl-over-slf4j" and "commons-logging" so that
> "jcl-over-slf4j" appears ahead of "commons-logging" in the classpath. In this
> way, "jcl-over-slf4j" is used as intended.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
