[ https://issues.apache.org/jira/browse/TINKERPOP-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786126#comment-17786126 ]
ASF GitHub Bot commented on TINKERPOP-3016: ------------------------------------------- kenhuuu commented on code in PR #2343: URL: https://github.com/apache/tinkerpop/pull/2343#discussion_r1393504432 ########## tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java: ########## @@ -72,8 +72,8 @@ public final class TinkerTransactionGraph extends AbstractTinkerGraph { private final TinkerTransaction transaction = new TinkerTransaction(this); - protected Map<Object, TinkerElementContainer<TinkerVertex>> vertices = new ConcurrentHashMap<>(); - protected Map<Object, TinkerElementContainer<TinkerEdge>> edges = new ConcurrentHashMap<>(); + final Map<Object, TinkerElementContainer<TinkerVertex>> vertices = new ConcurrentHashMap<>(); Review Comment: Nit: explicitly state what the access modifer should be. > TinkerTransactionGraph can incorrectly handle some read operations. > ------------------------------------------------------------------- > > Key: TINKERPOP-3016 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3016 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph > Affects Versions: 3.7.0 > Reporter: Valentyn Kahamlyk > Assignee: Valentyn Kahamlyk > Priority: Critical > > With some combination of reading operations, `TinkerTransactionGraph` may > return not the current Element value, but the cached one. > This may also cause update operations to fail with `Conflict: element > modified in another transaction` exception. -- This message was sent by Atlassian Jira (v8.20.10#820010)