[
https://issues.apache.org/jira/browse/TINKERPOP-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791725#comment-17791725
]
ASF GitHub Bot commented on TINKERPOP-3017:
-------------------------------------------
xiazcy commented on code in PR #2366:
URL: https://github.com/apache/tinkerpop/pull/2366#discussion_r1411086068
##########
gremlin-go/driver/anonymousTraversal.go:
##########
@@ -22,7 +22,7 @@ package gremlingo
// AnonymousTraversalSource interface for generating anonymous traversals.
type AnonymousTraversalSource interface {
// WithRemote used to set the DriverRemoteConnection within the
AnonymousTraversalSource
- WithRemote(drc *DriverRemoteConnection) *GraphTraversalSource
+ With(drc *DriverRemoteConnection) *GraphTraversalSource
Review Comment:
Are we just deprecating the usage? If so, we should keep WithRemote() in
addition to adding With(), as removing it will remove the method implementation
from the interface. I.e.:
```suggestion
With(drc *DriverRemoteConnection) *GraphTraversalSource
// WithRemote used to set the DriverRemoteConnection within the
AnonymousTraversalSource
//
// Deprecated: WithRemote replaced by With
WithRemote(remote *DriverRemoteConnection) *GraphTraversalSource
```
> Simplify TraversalSource creation from AnonymousTraversalSource
> ---------------------------------------------------------------
>
> Key: TINKERPOP-3017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.6.5
> Reporter: Stephen Mallette
> Priority: Major
> Labels: breaking
>
> Currently {{traversal()}} makes the user choose {{withRemote()}} or
> {{withEmbedded()}}. We could simplify by just making it {{with()}} and
> deprecating the old stuff. Also remove the long deprecated {{withGraph()}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
