[
https://issues.apache.org/jira/browse/TINKERPOP-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792251#comment-17792251
]
ASF GitHub Bot commented on TINKERPOP-2995:
-------------------------------------------
Cole-Greer commented on code in PR #2298:
URL: https://github.com/apache/tinkerpop/pull/2298#discussion_r1412545345
##########
docs/src/dev/developer/release.asciidoc:
##########
@@ -120,6 +120,7 @@ during this period.
.. Run the full integration test suite: `docker/build.sh -t -i -n`
.. Build and test the Docker images: `mvn clean install -pl
gremlin-server,gremlin-console -DdockerImages`
.. Ensure that the Gremlin.Net.Template gets packaged successfully: `mvn clean
install -pl :gremlin-dotnet-source -Dnuget`
+.. Ensure that the GLV examples are compiling and running successfully: `bash
run_examples.sh`
Review Comment:
```suggestion
.. Ensure that the GLV examples are compiling and running successfully:
`bin/run_examples.sh`
```
##########
gremlin-driver/src/main/java/examples/dependency-reduced-pom.xml:
##########
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
I don't think a dependency-reduced-pom is necessary here, I believe you can
get away with deleting this file.
##########
docs/src/reference/gremlin-variants.asciidoc:
##########
@@ -1201,8 +1224,8 @@ Connection Pool Status (size=1 max=5 min=1 toCreate=0
bin=0)
anchor:java-application-examples[]
anchor:gremlin-archetypes[]
-[[gremlin-java-examples]]
-=== Application Examples
+[[gremlin-java-archetypes]]
+=== Application Archetypes
Review Comment:
Based off of
https://lists.apache.org/thread/qr0f2cwc6bx5v0wdf1oyo4q6k58l1vf0, I believe we
are clear to remove the archetypes entirely at this point. I'm somewhat
indifferent if that is done in this PR or separately in the future.
> Create Sample Applications in each GLV
> --------------------------------------
>
> Key: TINKERPOP-2995
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2995
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, go, javascript, python
> Affects Versions: 3.5.7
> Reporter: Yang Xia
> Priority: Major
>
> It would be great to have working example applications for each GLV, with
> basic traversal examples and common connection settings.
> Currently we have an `example.py` for python, but it is very minimal. There
> is also an `example.go` for golang, but that appears to be outdated. As far
> as I know, dotnet only has templates and javascript doesn't have any examples
> at all.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
