[
https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801067#comment-17801067
]
ASF GitHub Bot commented on TINKERPOP-2872:
-------------------------------------------
codecov-commenter commented on PR #2422:
URL: https://github.com/apache/tinkerpop/pull/2422#issuecomment-1871620991
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`b4f3307`)](https://app.codecov.io/gh/apache/tinkerpop/commit/b4f33076bc290fc8b34aae03d1675b1a2b38775b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
76.17% compared to head
[(`f0d22d3`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
71.05%.
> Report is 27 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #2422 +/- ##
=============================================
- Coverage 76.17% 71.05% -5.13%
=============================================
Files 1083 25 -1058
Lines 64999 3942 -61057
Branches 7259 0 -7259
=============================================
- Hits 49516 2801 -46715
+ Misses 12785 950 -11835
+ Partials 2698 191 -2507
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Inconsistency in comparing Elements in JavaScript tests
> -------------------------------------------------------
>
> Key: TINKERPOP-2872
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2872
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.0
> Reporter: Valentyn Kahamlyk
> Priority: Major
>
> In most GLV's we consider Elements the same when they have the same ID.
> In JavaScript tests used [member wise
> comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176]
> Make it work like the others GLV's, just compare ID.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
