[
https://issues.apache.org/jira/browse/TINKERPOP-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802255#comment-17802255
]
ASF GitHub Bot commented on TINKERPOP-3029:
-------------------------------------------
codecov-commenter commented on PR #2424:
URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1875641877
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`e86eed2`)](https://app.codecov.io/gh/apache/tinkerpop/commit/e86eed20a868d5ba8fcf64939f032b87093811c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
75.16% compared to head
[(`76df767`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
71.23%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.6-dev #2424 +/- ##
=============================================
- Coverage 75.16% 71.23% -3.93%
=============================================
Files 1057 25 -1032
Lines 63470 3772 -59698
Branches 6936 0 -6936
=============================================
- Hits 47706 2687 -45019
+ Misses 13191 898 -12293
+ Partials 2573 187 -2386
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2424?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Gremlin.Net: Traversal enumeration fails on .NET 8
> --------------------------------------------------
>
> Key: TINKERPOP-3029
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3029
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.5.8, 3.6.6, 3.7.1
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Critical
>
> This has been reported by Eric Sites on the dev mailing list:
> [https://lists.apache.org/thread/snztwgk3s18h83mx8ql455hmx6ncl2r4]
> ----
> I am having a lot of issues using the Gremlin.Net driver version 3.7.1 with
> .Net 8.
> It is almost entirely unusable.
> Any request that uses an Iterator throws an exception ({{{}MoveNext{}}},
> {{{}Next{}}}, {{{}Iterate{}}}).
> {{{}System.InvalidOperationException: Enumeration has not started. Call
> MoveNext{}}}.
> Tracked it down to a change in .Net 8 {{IEnumerable<T>.Current}} behavior.
> Here is an issue about this filed in dotnet runtime:
> [https://github.com/dotnet/runtime/issues/85243]
> New bad code:
> {code:java}
> var enumerator = saves.GetEnumerator();
> while (enumerator.Current == null) // <- Throws exception now
> {
> if (!enumerator.MoveNext())
> return list;
> }
> {code}
> Should be changed to something like this:
> {code:java}
> while (enumerator.MoveNext())
> {
> var item = enumerator.Current;
> }
> {code}
> Here is an example of the issue in the Gremlin.Net code:
> [https://github.com/apache/tinkerpop/blob/e8b9532fc0ec811460e97ebf5e00b8b9ec9192ac/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs#L132]
> {code:java}
> private object? GetCurrent()
> {
> // Use dynamic to object to prevent runtime dynamic conversion evaluation
> return TraverserEnumerator.Current?.Object;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
