[ 
https://issues.apache.org/jira/browse/TINKERPOP-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815428#comment-17815428
 ] 

ASF GitHub Bot commented on TINKERPOP-2862:
-------------------------------------------

codecov-commenter commented on PR #2483:
URL: https://github.com/apache/tinkerpop/pull/2483#issuecomment-1932820461

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`fae51e8`)](https://app.codecov.io/gh/apache/tinkerpop/commit/fae51e87e7362648e53e58c66206a3a0442caa99?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 76.16% compared to head 
[(`5a30307`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 71.08%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2483      +/-   ##
   ============================================
   - Coverage     76.16%   71.08%   -5.09%     
   ============================================
     Files          1085       25    -1060     
     Lines         65191     3949   -61242     
     Branches       7289        0    -7289     
   ============================================
   - Hits          49654     2807   -46847     
   + Misses        12836      951   -11885     
   + Partials       2701      191    -2510     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   




> A grammar in TinkerPop should accept withoutStrategies
> ------------------------------------------------------
>
>                 Key: TINKERPOP-2862
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2862
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language
>    Affects Versions: 3.6.1, 3.5.4
>            Reporter: Norio Akagi
>            Priority: Major
>
> In our Grammar, we have {{withStrategies}} but not {{{}withoutStrategies{}}}.
> [https://github.com/apache/tinkerpop/blob/08afd4e475b56189500c31361b624ecc687e8b7b/gremlin-language/src/main/antlr4/Gremlin.g4#L65]
>  
> We should support so that a caller can disable a specific TinkerPop optimizer 
> at will. Note that graph providers can have their own Strategy, which may be 
> out of scope of {{withoutStrategies.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to