[
https://issues.apache.org/jira/browse/TINKERPOP-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817387#comment-17817387
]
ASF GitHub Bot commented on TINKERPOP-3030:
-------------------------------------------
FlorianHockmann commented on PR #2468:
URL: https://github.com/apache/tinkerpop/pull/2468#issuecomment-1943802015
> In general I like the idea of testing both .NET 6 and .NET 8 in GHA
similar to how Java is currently setup (I don't see a need for contributors to
run both locally)
I agree in general. I would also like to just execute the tests in GHA for
.NET 6 and 8 without requiring contributors to have both installed, but I can't
find a solution for this which doesn't require ugly workarounds.
We can't just configure this for GHA unfortunately. Instead, we need to add
both versions as `TargetFrameworks` to the `csproj` config files of the test
projects like this to let the tests run on both versions:
```xml
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
```
But if we do that, then you also need to have both installed in order to
execute the tests. If you only have .NET 8 installed, then you'll get an error:
```
Testhost process for source(s)
'[...]/tinkerpop/gremlin-dotnet/test/Gremlin.Net.UnitTest/bin/Debug/net6.0/Gremlin.Net.UnitTest.dll'
exited with error: You must install or update .NET to run this application.
App:
[...]/tinkerpop/gremlin-dotnet/test/Gremlin.Net.UnitTest/bin/Debug/net6.0/testhost.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
```
So, if we want to execute the tests for both versions in GHA, then we also
need to test them like this locally which means that all contributors need to
have both versions installed.
But since you already cast your vote and the PR has been open for 2 weeks
already (longer than our 7 day cool down time), I'll wait a few more days in
case any one else has any insights on this and merge the PR if not.
> Update to .NET 8
> ----------------
>
> Key: TINKERPOP-3030
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3030
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.5.8, 3.6.6, 3.7.1
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Blocker
>
> .NET 8 is now the latest LTS release so we should update to it.
> We need to do that on all release branches so contributors only need to have
> one version of .NET installed on their systems.
> This also means that we test by default with .NET 8 which would have shown
> problems like the one described in TINKERPOP-3029.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
