[
https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834281#comment-17834281
] ASF GitHub Bot commented on TINKERPOP-3068: ------------------------------------------- codecov-commenter commented on PR #2544: URL: https://github.com/apache/tinkerpop/pull/2544#issuecomment-2039672224 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `66.36637%` with `224 lines` in your changes are missing coverage. Please review. > Project coverage is 76.50%. Comparing base [(`d9e34fb`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d9e34fb4678c29ffa167066de45a9fa7329a319a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1d671f3`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 31 commits behind head on 3.6-dev. | [Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/language/grammar/DefaultGremlinBaseVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FDefaultGremlinBaseVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0RlZmF1bHRHcmVtbGluQmFzZVZpc2l0b3IuamF2YQ==) | 0.00% | [137 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rpop/gremlin/language/grammar/ArgumentVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FArgumentVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0FyZ3VtZW50VmlzaXRvci5qYXZh) | 76.47% | [21 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...remlin/language/grammar/GenericLiteralVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FGenericLiteralVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0dlbmVyaWNMaXRlcmFsVmlzaXRvci5qYXZh) | 68.42% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/tinkerpop/gremlin/console/GremlinGroovysh.groovy](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-console%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fconsole%2FGremlinGroovysh.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvR3JlbWxpbkdyb292eXNoLmdyb292eQ==) | 52.94% | [6 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...emlin/language/grammar/TraversalMethodVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FTraversalMethodVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL1RyYXZlcnNhbE1ldGhvZFZpc2l0b3IuamF2YQ==) | 95.39% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/tinkerpop/gremlin/jsr223/JavaTranslator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fjsr223%2FJavaTranslator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9qc3IyMjMvSmF2YVRyYW5zbGF0b3IuamF2YQ==) | 60.00% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../gremlin/language/grammar/NoOpTerminalVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FNoOpTerminalVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL05vT3BUZXJtaW5hbFZpc2l0b3IuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...p/gremlin/language/grammar/GremlinAntlrToJava.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FGremlinAntlrToJava.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0dyZW1saW5BbnRsclRvSmF2YS5qYXZh) | 83.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...op/gremlin/console/commands/BytecodeCommand.groovy](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-console%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fconsole%2Fcommands%2FBytecodeCommand.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvY29tbWFuZHMvQnl0ZWNvZGVDb21tYW5kLmdyb292eQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../gremlin/console/commands/GremlinSetCommand.groovy](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&filepath=gremlin-console%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fconsole%2Fcommands%2FGremlinSetCommand.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvY29tbWFuZHMvR3JlbWxpblNldENvbW1hbmQuZ3Jvb3Z5) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## 3.6-dev #2544 +/- ## ============================================= + Coverage 75.14% 76.50% +1.36% - Complexity 12346 13178 +832 ============================================= Files 1058 1061 +3 Lines 63610 61293 -2317 Branches 6962 7298 +336 ============================================= - Hits 47801 46895 -906 + Misses 13225 11891 -1334 + Partials 2584 2507 -77 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Make serviceName and mergedParams public for provider usage in CallStep > ----------------------------------------------------------------------- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process > Reporter: Saikiran Boga > Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
