[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834901#comment-17834901
]
ASF GitHub Bot commented on TINKERPOP-3060:
-------------------------------------------
codecov-commenter commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2042581374
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 76.49%. Comparing base
[(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`8b1e8bd`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 54 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #2546 +/- ##
=============================================
+ Coverage 76.14% 76.49% +0.34%
- Complexity 13152 13174 +22
=============================================
Files 1084 1059 -25
Lines 65160 61282 -3878
Branches 7285 7297 +12
=============================================
- Hits 49616 46876 -2740
+ Misses 12839 11892 -947
+ Partials 2705 2514 -191
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Dependency inconsistency between modules.
> -----------------------------------------
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Wei Zhao
> Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> ---------
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> ---------
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
