[
https://issues.apache.org/jira/browse/TINKERPOP-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852066#comment-17852066
]
ASF GitHub Bot commented on TINKERPOP-3082:
-------------------------------------------
ministat commented on code in PR #2634:
URL: https://github.com/apache/tinkerpop/pull/2634#discussion_r1626069017
##########
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java:
##########
@@ -51,6 +51,15 @@
* @author Marko A. Rodriguez (http://markorodriguez.com)
*/
public class SparkTest extends AbstractSparkTest {
+ @Test
+ public void testCustomizedSparkAppName() {
+ final String appName = "SparkAppNameTest";
+ final org.apache.spark.SparkConf sparkConfiguration = new
org.apache.spark.SparkConf();
Review Comment:
No special purpose. My impression is many "import" sometimes brings trouble
and confusion to the current file namespace, like the
org.apache.commons.configuration2.Configuration and
org.apache.commons.configuration.Configuration. So, I tried to avoid that. In
addition, org.apache.spark.SparkConf is not too long and not impact the reading.
##########
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java:
##########
@@ -51,6 +51,15 @@
* @author Marko A. Rodriguez (http://markorodriguez.com)
*/
public class SparkTest extends AbstractSparkTest {
+ @Test
+ public void testCustomizedSparkAppName() {
Review Comment:
Good idea. I'll add one.
> Tinkerpop hardcoded the Spark AppName
> -------------------------------------
>
> Key: TINKERPOP-3082
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3082
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.7.2
> Reporter: Redriver
> Priority: Major
> Attachments: Screenshot 2024-06-03 at 16.14.17.png
>
>
> When I run gremlin through SparkGraphComputer, the SparkUI always displays
> the Spark App as "[Apache TinkerPop's
> Spark-Gremlin|http://hdc49-mcc10-01-0510-3405-002-tess0097.stratus.rno.ebay.com:4040/]";
> (see
> https://github.com/apache/tinkerpop/blob/master/spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/Spark.java#L51)
> which confused users if I run multiple gremlin with SparkGraphComputer.
> It should allow override the Spark App name if user wants to. If user does
> not specify the Spark app name, we can provide the default one.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
