[
https://issues.apache.org/jira/browse/TINKERPOP-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852584#comment-17852584
]
ASF GitHub Bot commented on TINKERPOP-3028:
-------------------------------------------
vkagamlyk commented on code in PR #2640:
URL: https://github.com/apache/tinkerpop/pull/2640#discussion_r1628459561
##########
gremlin-dotnet/build/generate.groovy:
##########
@@ -175,6 +137,11 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
' list.RemoveAt(0);\n' +
' return f.Invoke(g, parameters);\n' +
' }\n' +
+ '\n' +
+ ' public static bool HasTraversal(string scenarioName)\n' +
Review Comment:
where is `HasTraversal` used?
> Convert translators to make use of the grammar
> ----------------------------------------------
>
> Key: TINKERPOP-3028
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3028
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.6.6
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> {{Translator}} infrastructure uses bytecode and reflection which has a number
> of technical imperfections and exemptions for it to work properly. Switching
> to the grammar for translation simplifies the code, removes friction and
> complexity when generating GLV tests, and should perform better. The focus
> for this issue is the Java series of translators which are relied on quite
> heavily.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
