[
https://issues.apache.org/jira/browse/TINKERPOP-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888780#comment-17888780
]
ASF GitHub Bot commented on TINKERPOP-3088:
-------------------------------------------
Cole-Greer commented on PR #2827:
URL: https://github.com/apache/tinkerpop/pull/2827#issuecomment-2408147576
Looks like there's a few tests in server and spark which need corresponding
updates from Long to Integer. Other than that LGTM.
VOTE +1 pending test fixes.
> SumGlobalStep returns a long value even the highest common type's bit <= 32
> ---------------------------------------------------------------------------
>
> Key: TINKERPOP-3088
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3088
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.2
> Reporter: Norio Akagi
> Priority: Minor
>
> This happens because in
> {noformat}
> @Override
> public S projectTraverser(final Traverser.Admin<S> traverser) {
> return (S) mul(traverser.get(), traverser.bulk());
> }{noformat}
> It multiplies with bulk, which is Long type, so upcasted. This is at least
> not in semantics and unexpected behavior
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
