Since there were no concerns with the above, I'm assuming lazy consensus and will be making a PR to remove the GraphReader/GraphWriter. This effectively means that GraphSONv1-3 can't be used (since they aren't used for network IO either) so I'll be moving forward with removing them as well. I'll also be removing serializers in GraphSONv4 that were agreed to in https://lists.apache.org/thread/q7h5yzd2r064lv82njbmt6lmty4s24y7 . Complete serializers/deserializers will only remain for: Byte Short Int Long Char String DateTime Double Float List Map Set UUID Edge Path Property Tree Graph Vertex VertexProperty Direction T BigDecimal BigInteger Binary Boolean CompositePDT PrimitivePDT Duration
On Tue, Oct 15, 2024 at 3:11 PM Ken Hu <kenhu...@gmail.com> wrote: > Hi All, > > A previous DISCUSS thread ( > https://lists.apache.org/thread/0546dhhsy4bksc8o05kvpstffcd7nlrd) decided > that only GraphBinary4 and GraphSON4 should be supported in the server. > However, this only meant that GraphSON4 would be supported for network IO > as a MessageSerializer. There is an open question about support for > GraphSON as a GraphReader/GraphWriter. I'm suggesting that we go a step > further and completely remove the GraphSONReader and GraphSONWriter so that > GraphSON is no longer an IO format that can be used for Graph > serialization. The reason I'm suggesting this is due to the fact that, in > some ways, GraphSON4 is a cut down version of GraphSON3. There are fewer > type serializers (e.g. the only java.time serializer supported is > OffsetDateTime). Also, the format is slightly changed which means that a > translator is needed or the old GraphSONMappers would need to be kept > around despite their diminished use. > > Instead, we should just try to update the version of Kryo supported and > make Gryo the main format for Graph serialization. Alternatively, we could > move to another format. > > Does anyone have any thoughts or concerns about removing GraphSON as an IO > format? > > Thanks, > Ken >
