[
https://issues.apache.org/jira/browse/TINKERPOP-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910845#comment-17910845
]
ASF GitHub Bot commented on TINKERPOP-3124:
-------------------------------------------
kenhuuu commented on code in PR #2964:
URL: https://github.com/apache/tinkerpop/pull/2964#discussion_r1906171663
##########
docs/src/upgrade/release-3.7.x.asciidoc:
##########
@@ -30,6 +30,28 @@ complete list of all the modifications that are part of this
release.
=== Upgrading for Users
+==== Improved Server Memory Management
+
+A TinkerPop-specific `MessageSizeEstimator` was added to more accurately
measure the size of responses being written
+back to the client. With a more accurate measurement, the server is able to
better prevent exhaustion of direct memory
+by overly eager channels writing large result sets to slower clients. Overall,
this change should help reduce the
+likelihood of the server hitting `OutOfMemoryExceptions` and other performance
problems that may appear under certain
+workloads and network conditions.
+
+It is worth nothing that logging around the `writeBufferHighWaterMark` has
been modified to include a bit more
Review Comment:
```suggestion
It is worth noting that logging around the `writeBufferHighWaterMark` has
been modified to include a bit more
```
> MessageSizeEstimator is not sizing Frame instances properly
> -----------------------------------------------------------
>
> Key: TINKERPOP-3124
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3124
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.7.3
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Critical
>
> Netty has a {{MessageSizeEstimator}} which helps estimate the number of bytes
> in the channel's direct memory buffer. Each channel checks the count against
> the {{writeBufferHighWaterMark}} to determine if writes should be paused to
> avoid OOMs. The default implementation of the estimator from Netty does not
> take {{Frame}} into account and therefore the estimations are off.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
