[
https://issues.apache.org/jira/browse/TINKERPOP-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924739#comment-17924739
]
ASF GitHub Bot commented on TINKERPOP-2489:
-------------------------------------------
Cole-Greer commented on code in PR #3020:
URL: https://github.com/apache/tinkerpop/pull/3020#discussion_r1945727572
##########
gremlin-server/src/main/bin/gremlin-server.sh:
##########
@@ -96,7 +96,7 @@ fi
# Build Java CLASSPATH
CP="$GREMLIN_HOME/conf/"
-CP="$CP":$( echo $GREMLIN_HOME/lib/*.jar . | sed 's/ /:/g')
+CP="$CP":$( find "$GREMLIN_HOME/lib" -name "*.jar" -print | tr '\n' ':' )
Review Comment:
There's a slight difference in the output of these 2 commands.
`echo $GREMLIN_HOME/lib/*.jar . | sed 's/ /:/g'` produces something like
this:
`path_to_x.jar:path_to_y.jar:path_to_z.jar:.`
whereas `find "$GREMLIN_HOME/lib" -name "*.jar" -print | tr '\n' ':'`
produces something like this:
`path_to_x.jar:path_to_y.jar:path_to_z.jar:`
The new classpath is missing the current directory (`.`).
Also just a small nit, the new classpath is ending with a trailing `:`, I
don't think this causes any issues but it is a bit atypical.
> Server doesn't start if folder has spaces
> -----------------------------------------
>
> Key: TINKERPOP-2489
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2489
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Divij Vaidya
> Priority: Major
>
> Repro steps:
> 1. Download the server zip.
> 2. Unzip the binary.
> 3. Rename the unzipped folder and add a space, e.g.
> {code:java}
> apache-tinkerpop-gremlin-server-3.4.9 my{code}
> 4. Start the server
> {code:java}
> ./bin/gremlin-server.sh start{code}
> 5. The server will fail to start (check status) with the error "Error: Could
> not find or load main class my.conf.log4j-server.properties"
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
