[ 
https://issues.apache.org/jira/browse/TINKERPOP-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925072#comment-17925072
 ] 

ASF GitHub Bot commented on TINKERPOP-3130:
-------------------------------------------

andreachild commented on code in PR #3023:
URL: https://github.com/apache/tinkerpop/pull/3023#discussion_r1947255302


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/translator/PythonTranslatorTest.java:
##########
@@ -61,6 +60,13 @@ public void shouldTranslateOption() {
         assertEquals("g.V().has('person','name','marko')", gremlinAsPython);
     }
 
+    @Test
+    public void shouldTranslateValues() {

Review Comment:
   Nit: Agree doesn't hurt to keep the `values` test. Should the `none()` 
translation test be added?





> Better consistency for none()/discard() usage
> ---------------------------------------------
>
>                 Key: TINKERPOP-3130
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3130
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language, process
>    Affects Versions: 3.7.3
>            Reporter: Stephen Mallette
>            Priority: Minor
>
> {{g.V().none().path()}} should work and does so in the console, but the 
> grammar fails to parse it because it treats {{none()}} in a special way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to