[
https://issues.apache.org/jira/browse/TINKERPOP-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926110#comment-17926110
]
ASF GitHub Bot commented on TINKERPOP-3024:
-------------------------------------------
andreachild commented on code in PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#discussion_r1951361131
##########
gremlin-python/src/main/python/gremlin_python/process/graph_traversal.py:
##########
@@ -2485,7 +2502,9 @@ def where(*args):
statics.add_static('hasKey', hasKey)
-statics.add_static('has_key', has_key_)
+statics.add_static('has_key_', has_key_)
Review Comment:
I don't think you need to add this static import to the deprecated
`has_key_`, you can just change the existing static `has_key` to point to the
new `has_key` instead of the deprecated `has_key_`.
> Deprecate has_key_() for has_key() in python
> --------------------------------------------
>
> Key: TINKERPOP-3024
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3024
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.6.6
> Reporter: Stephen Mallette
> Priority: Major
>
> {{has_key_()}} was added to python because it was reserved on {{Dictionary}}
> but that was removed in python 3. since TinkerPop doesn't support python 2
> anymore there is little need for this difference anymore. deprecate the
> underscore suffixed version and add the property {{has_key()}} version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
